#4324 netpbm11-10.63.01-1 to provide netpbm on 10.9

Added_to_Fink
closed-fixed
5
2013-07-28
2013-07-21
No

Bring back netpbm11 packaging so that 10.9 can have a netpbm that support libjpeg9 and libpng16. Added missing InfoTest by using INSTALL_MAKE_CHECK approach at end of InstallScript. The build also is switched off of BuildDependsOnly: True to BuildDependsOnly: False and uses BuildConflicts: %n (<< %n-%v-%r), netpbm, netpbm10 as well as eliminating the use of

NoSetMAKEFLAGS: true
NoSetLDFLAGS: true
SetLIBRARY_PATH: %p/lib

otherwise fink validation fails due to…

Use of headers from prohibited installed packages:
netpbm11
Please fix build process to avoid seeing them.

for 'fink -m'. Tested on 10.7, 10.8 and 10.9 with the same test suite results on each…

Test summary:

SUCCESS 79
FAILURE 9
TOTAL SUPPORTED 88
==================

Discussion

  • Jack Howarth

    Jack Howarth - 2013-07-21

    Info file for netpbm11-10.63.01-1

     
  • Jack Howarth

    Jack Howarth - 2013-07-21

    Patch file for netpbm11-10.63.01-1

     
  • Jack Howarth

    Jack Howarth - 2013-07-21

    Info file for netpbm11-10.63.01-1 with minor Shlibs entry fix.

     
  • Hanspeter Niederstrasser

    I will look at this early this week. Have to make sure that the 'stable' netpbm tree won't decide to jump so version to 11 and thus conflict with the 'advanced' tree (netpbm11). I think it's pretty safe that it won't, but I just want to verify.

     
    • Daniel Macks

      Daniel Macks - 2013-07-24

      Call it netpbm11-advanced and bury the library in a subdir?

       
  • Jack Howarth

    Jack Howarth - 2013-07-22

    Both transfix and xfig are now updated in 10.7 tree to build on future os and can be used to test netpbm-bin from netpbm11-10.63.01.

     
  • Daniel Macks

    Daniel Macks - 2013-07-24

    BuildConflicts is the last-resort solution to anything. If f-p-p whines about headers, there is a mistake in the order of -I flags.

     
  • Daniel Macks

    Daniel Macks - 2013-07-24

    Why does it need BuildDependsOnly:false? That's a pretty unusual situation and certainly deserves a DescPackaging or other note in the .info.

     
  • Hanspeter Niederstrasser

    I have no idea why BConflicts is needed or the need for BuildDependsOnly: false. I have attached my working copy. It also drops the Tdep on coreutils.

    It only fails 3 tests, and upstream has been informed about them. Please test on futureos (knowing that ppmcie.test, ppmhist.test, and pnmpsnr.test fail).

     
    • Jack Howarth

      Jack Howarth - 2013-07-24

      Tested on Future OS with the results...

      Test summary:

      SUCCESS 80
      FAILURE 3
      NOT SUPPORTED 5
      TOTAL SUPPORTED 83
      ==================

      The packaging completes 'fink -m' with the following additional change...

      --- netpbm11-shlibs.info.orig 2013-07-24 12:28:52.000000000 -0400
      +++ netpbm11-shlibs.info 2013-07-24 12:32:07.000000000 -0400
      @@ -47,6 +47,9 @@
      # run tests now if needed
      if [ -f %b/INSTALL_MAKE_CHECK ]; then
      chmod u+x %b/test/*.test
      + perl -pi -e 's|ppmcie.test|# ppmcie.test|g' %b/test/Test-Order
      + perl -pi -e 's|ppmhist.test|# ppmhist.test|g' %b/test/Test-Order
      + perl -pi -e 's|pnmpsnr.test|# pnmpsnr.test|g' %b/test/Test-Order
      export DYLD_LIBRARY_PATH=%b/package/lib
      make check pkgdir=pwd/package resultdir=pwd/test-out || exit 2
      fi

      Please go ahead and commit with the current packaging with that change. FYI, the packaging produces no fink-package-precedence errors when built with itself already installed.

       
  • Jack Howarth

    Jack Howarth - 2013-07-24

    Note that the current scheme used in netpbm10 for InfoTest won't work for netpbm11 as there is a specific execution order dictated in test/Test-Order.

     
    • Hanspeter Niederstrasser

      I'm aware. netpbm11 uses 'make check'. netpbm10 doesn't offer that and so has a manual scheme.

       
  • Hanspeter Niederstrasser

    Two tests fixed. Waiting on the 3rd one which should be soon.

     
  • Jack Howarth

    Jack Howarth - 2013-07-28

    Any progress? If not can we just commit the current packaging for now and fix the last test later?

     
  • Hanspeter Niederstrasser

    • labels: --> Updated libversion
    • status: open --> closed-fixed
    • Group: Undergoing_Validation --> Added_to_Fink
     
  • Hanspeter Niederstrasser

    netpbm11 is now in CVS.

     

Log in to post a comment.