Menu ▾ ▴

#24 Please apply the bcel changes upstream

3.0.0
open
nobody
None
5
2014-07-07
2013-08-29
Sylvestre Ledru
No

We are in the process of packaging findbugs in Debian and Ubuntu. However, the patch applied against bcel causes a lot of issues in term of packaging.
It would be great if you could get in touch with bcel upstream and make suree that official release contains your changes.
Thanks

Discussion

  • Richard Fearn

    Richard Fearn - 2014-07-07

    I think this was probably filed against FindBugs 2.0.x as it's out-of-date now (there isn't a BCEL patch any more).

    The solution we used for the Fedora FindBugs package was to have a second BCEL package called findbugs-bcel, with the FindBugs patch applied. FindBugs builds/runs using this alternative package.

    The changes in the BCEL patch were eventually applied upstream. See:

    https://issues.apache.org/jira/browse/BCEL-163

    At that point the findbugs-bcel package in Fedora switched to use a snapshot of BCEL:

    http://pkgs.fedoraproject.org/cgit/findbugs-bcel.git/commit/?id=2e22158c3cbed144e062f811180dc99462fc52e6

    FindBugs 3.0.0 also uses a snapshot of BCEL. The manifest in the JAR says it's revision 1535952:

    $ unzip -p bcel-6.0-SNAPSHOT.jar META-INF/MANIFEST.MF | grep Implementation-Build
Implementation-Build: trunk@r1535952; 2013-12-01 20:11:08-0500
     

  • Andrey Loskutov

    Andrey Loskutov - 2014-07-07

    Richard, do you also propose to close this ticket?
    Andrey

     

  • Richard Fearn

    Richard Fearn - 2014-07-07

    Richard, do you also propose to close this ticket?

    Not my decision really. It depends on what the Debian/Ubuntu packagers decide to do.

    If they're packaging 3.0.0, they're going to have a similar problem (FindBugs using its own version of BCEL, not an 'official' one).

    Just wanted to give a bit more info about what I've done for Fedora...

     

Log in to post a comment.