Menu

#1269 Eclipse Plugin: UseEqualsResolution.java is zero-length?

3.0.0
closed-fixed
None
5
2014-04-30
2014-04-24
No

I was looking at the 2.0.3 source code, but I believe that this isn't specific to 2.0.3.

On code.google.com, UseEqualsResolution.java seems to be an empty file:

https://code.google.com/p/findbugs/source/browse/eclipsePlugin/src/edu/umd/cs/findbugs/plugin/eclipse/quickfix/UseEqualsResolution.java

and code.google.com makes it look as though it has always been thus, from the initial checkin (to SVN) on Feb 13 2007. No, that wasn't a Friday.

However, patch 149:

http://sourceforge.net/p/findbugs/patches/149/

included a perfectly good nonempty version of UseEqualsResolution.java (167 lines), so presumably something somewhere silently ate it between then and now?

Discussion

  • Andrey Loskutov

    Andrey Loskutov - 2014-04-26
    • status: open --> open-fixed
    • assigned_to: Andrey Loskutov
    • Group: 2.0.4 --> 3.0.0
     
  • Andrey Loskutov

    Andrey Loskutov - 2014-04-26

    Yep, the original patch was not fully applied.
    I've re-applied it, please check latest head commits.
    Thank you!
    Regards,
    Andrey

     
  • Andrey Loskutov

    Andrey Loskutov - 2014-04-26
    • status: open-fixed --> closed-fixed
     
  • Thomas Maslen

    Thomas Maslen - 2014-04-30

    [Hoping this won't trigger any silliness such as auto-reopening of the bug]

    Thanks. I haven't taken it for a spin, but yes, the repo looks pretty convincing now (not only the Java but the XML).

     

Log in to post a comment.