[Filterproxy-devel] Re: New module for FilterProxy

[Bob M. <mce...@us...>]

John F Waymouth [way...@wp...] wrote:
> (I can't reply to filterproxy-devel, I imagine, so I'll leave forwaring to
> you)
>=20
> > Yes, that's a bug, I'll look into it.  This really should have the
> > inside encloser <script>.
>=20
> That's what I'm thinking.  I do'nt think that any window.open in a
> <script> will be benign, and that's a good thing, because I can't exactly
> think of how to consistently parse the first arg for matches.  I suppose
> people could always exclude this rule for certain domains.

Yeah, I've avoided attacking javascript so far due to things like this.
I mean, to really correctly filter javascript, you have to solve the
Halting problem...  ;)  Other filters have been very successful though.

> > Looks good.  You sent this just as I was trying to find a site that has
> > popups.  Do you know of any?
>=20
> Sure.  www.sparkmatch.com.  I was using it as my testbed, because, if
> you're unlucky, sometimes 3 or 4 windows popup per page view.  This rule
> doesn't remove all of the popups on this site, because it has a few nasty
> tricks, like document.write()ing a <script> call to an ad server.  Should
> be filterable.

No popups on that site for me now! (at all)  In fact, that page didn't
render correctly under Netscape 4.5 (some javascript error).  People
that use document.write() to write their HTML should be taken out and
shot.  But, of course, so should Nutscape 4.x...  Somehow, with the
popups disabled, it renders correctly though.

> Oh, and don't forget, yahoo is supposedly debuting popups, hence the
> slashdot article :)

Not for us, it won't!  ;)  Thanks!

BTW, some other rules should be changed to reflect the change in
"inside" behavior (if you apply my patch):
    SCRIPTADS: strip regex #(ads\\.freecity\\.de|flycast\\.com|/RealMedia/a=
ds/)# inside tagblock <script> add encloser <script> alternate add balanced

BTW, have you seen the galeon/skipstone behavior WRT popups where they
open a new "tab" instead of a window?  An elegant solution, if you ask
me.  I hope mozilla adds tabs like that.

Cheers,
-- Bob

Bob McElrath (rsm...@st...)=20
Univ. of Wisconsin at Madison, Department of Physics