From: Matthew B. <mb...@ky...> - 2002-07-25 12:25:48
|
Well, hopefully this won't cause too much trouble... I've re-run all the .c and .h source through astyle. astyle --style=kr --indent=tab=2 -S *.c *.h Update before it's too late ^_^; The reason for this is I'm putting together a code standard, and decided that tabs aren't that bad (they can be whatever size -you- want them to be ;) -- Matthew (Darkstorm) Bevan mb...@ma... Margin Software, NECTI. http://www.marginsoftware.com Re-inventing the wheel, every time. - The PILLSBURY DOUGHBOY is CRYING for an END to BURT REYNOLDS movies!! |
From: David J. K. <dke...@ko...> - 2002-07-25 12:45:48
|
Whoa!!!!! Back the truck up. Tabs are *very* bad. Not every editor lets you choose tab width and it's not always convenient for people to change their editor configuration every time they want to edit the FileCaddy source code. This is a religious issue for me so as long as Kopsis is associated with FileCaddy the source will *not* use tabs for indenting! I initially ran everything through astyle to remove tabs for a reason. In the future, any "accross the board" changes like this need to be discussed on the mailing list before they are made and committed to CVS. -- - Dave Kessler President - Kopsis, Inc. http://kopsisengineering.com On Thu, Jul 25, 2002 at 05:27:22AM -0700, Matthew Bevan wrote: > Well, hopefully this won't cause too much trouble... I've re-run all the > .c and .h source through astyle. > > astyle --style=kr --indent=tab=2 -S *.c *.h > > Update before it's too late ^_^; The reason for this is I'm putting > together a code standard, and decided that tabs aren't that bad (they > can be whatever size -you- want them to be ;) > > -- > Matthew (Darkstorm) Bevan mb...@ma... > Margin Software, NECTI. http://www.marginsoftware.com > Re-inventing the wheel, every time. > > - The PILLSBURY DOUGHBOY is CRYING for an END to BURT REYNOLDS movies!! > > > > ------------------------------------------------------- > This sf.net email is sponsored by: Jabber - The world's fastest growing > real-time communications platform! Don't just IM. Build it in! > http://www.jabber.com/osdn/xim > _______________________________________________ > Filecaddy-developers mailing list > Fil...@li... > https://lists.sourceforge.net/lists/listinfo/filecaddy-developers |
From: Matthew B. <mb...@ky...> - 2002-07-25 14:17:50
|
On Thu, 2002-07-25 at 05:45, David J. Kessler wrote: > Whoa!!!!! Back the truck up. Tabs are *very* bad. Not every editor lets you > choose tab width and it's not always convenient for people to change their > editor configuration every time they want to edit the FileCaddy source code. > This is a religious issue for me so as long as Kopsis is associated with > FileCaddy the source will *not* use tabs for indenting! I initially ran > everything through astyle to remove tabs for a reason. Oh my. Alrighty then. How would you recommend we revert? Just do a astyle --style=kr -s2 --convert-tabs to get it back, or do some CVS trickery? I've investigated both and it seems it would be easier to do the astyle method. Tabs are religious to you, opening braces are to me. Still writing... arg.. > In the future, any "accross the board" changes like this need to be > discussed on the mailing list before they are made and committed to CVS. Of course. It won't happen again :( -- Matthew (Darkstorm) Bevan mb...@ma... Margin Software, NECTI. http://www.marginsoftware.com Re-inventing the wheel, every time. - Excellent day for drinking heavily. Spike the office water cooler. |
From: David J. K. <dke...@ko...> - 2002-07-25 14:45:33
|
On Thu, Jul 25, 2002 at 07:19:20AM -0700, Matthew Bevan wrote: > Oh my. Alrighty then. How would you recommend we revert? Just do a > astyle --style=kr -s2 --convert-tabs to get it back, or do some CVS > trickery? Trickery and version control should never be used in the same sentence :) The right way to "back out" the change is to not back it out at all, just run everything through astyle again and commit a new rev. > Tabs are religious to you, opening braces are to me. Still writing... > arg.. Opening braces? Do you mean consistent use or where they're located? I like K&R because it saves screen real estate and because I've been using it for the last 17 years, but if you'd rather see opening braces on their own line (Allman style), I can live with that. Whitesmith style (opening brace on new line *and* indented to match the enclosed block) kinda drives me nuts though and gnu style (indent the opening brace one level and then indent the enclosed block another level) is almost as annoying :) In fact when it comes to the GNU C style guide I think Torvalds had the right idea ... "First off, I'd suggest printing out a copy of the GNU coding standards, and NOT read it. Burn them, it's a great symbolic gesture." -- Dave Kessler President - Kopsis, Inc. http://kopsisengineering.com |