[File-extattr-commits] File-ExtAttr Changes, 1.40, 1.41 ExtAttr.xs, 1.24, 1.25 MANIFEST, 1.21, 1.22 TODO, 1.22, 1.23 helpers.c, 1.5, NONE helpers.h, 1.2, NONE

[Richard D. <ric...@us...>]

Update of /cvsroot/file-extattr/File-ExtAttr
In directory sc8-pr-cvs17.sourceforge.net:/tmp/cvs-serv22776

Modified Files:
	Changes ExtAttr.xs MANIFEST TODO 
Removed Files:
	helpers.c helpers.h 
Log Message:
setattr_warn must die -- too noisy

Index: ExtAttr.xs
===================================================================
RCS file: /cvsroot/file-extattr/File-ExtAttr/ExtAttr.xs,v
retrieving revision 1.24
retrieving revision 1.25
diff -C2 -d -r1.24 -r1.25
*** ExtAttr.xs	6 Apr 2008 09:12:47 -0000	1.24
--- ExtAttr.xs	6 Apr 2008 09:21:26 -0000	1.25
***************
*** 4,8 ****
  
  #include "ppport.h"
- #include "helpers.h"
  #include "portable.h"
  
--- 4,7 ----
***************
*** 31,38 ****
          attrvalue = SvPV(attrvalueSV, slen);
          rc = portable_setxattr(path, attrname, attrvalue, slen, flags);
!         if (rc < 0) {
!           setattr_warn("setxattr", attrname, errno);
            errno = -rc;
-         }
          RETVAL = (rc == 0);
  
--- 30,35 ----
          attrvalue = SvPV(attrvalueSV, slen);
          rc = portable_setxattr(path, attrname, attrvalue, slen, flags);
!         if (rc < 0)
            errno = -rc;
          RETVAL = (rc == 0);
  
***************
*** 55,62 ****
          attrvalue = SvPV(attrvalueSV, slen);
          rc = portable_fsetxattr(fd, attrname, attrvalue, slen, flags);
!         if (rc < 0) {
!           setattr_warn("fsetxattr", attrname, errno);
            errno = -rc;
-         }
          RETVAL = (rc == 0);
  
--- 52,57 ----
          attrvalue = SvPV(attrvalueSV, slen);
          rc = portable_fsetxattr(fd, attrname, attrvalue, slen, flags);
!         if (rc < 0)
            errno = -rc;
          RETVAL = (rc == 0);
  
***************
*** 92,98 ****
                  XSRETURN_UNDEF;
  
!             //print warning and return undef
              }else{
-                 setattr_warn("getxattr", attrname, errno);
                  Safefree(attrvalue);
                  errno = -attrlen;
--- 87,92 ----
                  XSRETURN_UNDEF;
  
!             //return undef
              }else{
                  Safefree(attrvalue);
                  errno = -attrlen;
***************
*** 135,141 ****
                  XSRETURN_UNDEF;
  
!             //print warning and return undef
              }else{
-                 setattr_warn("fgetxattr", attrname, errno);
                  Safefree(attrvalue);
                  errno = -attrlen;
--- 129,134 ----
                  XSRETURN_UNDEF;
  
!             //return undef
              }else{
                  Safefree(attrvalue);
                  errno = -attrlen;

--- helpers.h DELETED ---

Index: Changes
===================================================================
RCS file: /cvsroot/file-extattr/File-ExtAttr/Changes,v
retrieving revision 1.40
retrieving revision 1.41
diff -C2 -d -r1.40 -r1.41
*** Changes	6 Apr 2008 09:12:47 -0000	1.40
--- Changes	6 Apr 2008 09:21:22 -0000	1.41
***************
*** 24,27 ****
--- 24,31 ----
                   - Make sure I've actually addressed API concerns in #32670.
  
+     - (richdawe) File::ExtAttr no longer generate noisy warnings
+                  when an xattr system call fails. All error reporting
+                  is now via the function return values and $!.
+ 
  1.07 2007-12-15
  

Index: MANIFEST
===================================================================
RCS file: /cvsroot/file-extattr/File-ExtAttr/MANIFEST,v
retrieving revision 1.21
retrieving revision 1.22
diff -C2 -d -r1.21 -r1.22
*** MANIFEST	24 Feb 2008 10:17:48 -0000	1.21
--- MANIFEST	6 Apr 2008 09:21:26 -0000	1.22
***************
*** 12,17 ****
  flags.c
  flags.h
- helpers.h
- helpers.c
  extattr_bsd.h
  extattr_bsd.c
--- 12,15 ----

--- helpers.c DELETED ---

Index: TODO
===================================================================
RCS file: /cvsroot/file-extattr/File-ExtAttr/TODO,v
retrieving revision 1.22
retrieving revision 1.23
diff -C2 -d -r1.22 -r1.23
*** TODO	6 Apr 2008 09:12:47 -0000	1.22
--- TODO	6 Apr 2008 09:21:26 -0000	1.23
***************
*** 1,5 ****
  todo:
  * utf8
- * warnings
  * check that partition supports it, especially in unit test
  * docs, explain user_xattr, mount -o remount
--- 1,4 ----
***************
*** 7,11 ****
  * for "operation not supported" note must be prefixed with "user"
  * buffer size, reuse buffer?
- * Get rid of setattr_warn
  * Set $! to errno in xattr operations, for use in FUSE filesystems.
  * symbolic link handling (O_NOFOLLOW on Mac OS X)
--- 6,9 ----