[FieldML-automated1] Comment on revision r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 in fieldml-java2

[<fie...@go...>]

r.brit...@auckland.ac.nz commented on revision  
r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 in project fieldml-java2.
Details are at  
http://code.google.com/p/fieldml-java2/source/detail?r=472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5


Line-by-line comments:

File: /trunk/src/fieldml/BicubicHermiteTest.java  
(r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5)
===============================================================================

Line 77:         EnsembleParameters quadNodeList = new  
EnsembleParameters( "test_mesh.quad_nodes", globalNodesListDomain,  
meshDomain.getElementDomain() );
-------------------------------------------------------------------------------
meshDomain.getElementDomain() hides a subtlety.  In the serialisation, this  
will just be a direct reference to the Element domain, but in the Java  
code, it hints at an association with the meshDomain as well.

Either explicitly make the association with the mesh so that it appears in  
the serialisation as well, or directly refer to the element domain, without  
using the meshDomain.

Respond to these comments at  
http://code.google.com/p/fieldml-java2/source/detail?r=472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings