[FieldML-automated1] Comment on revision r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 in fieldml-java2

[<fie...@go...>]

r.brit...@auckland.ac.nz commented on revision  
r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 in project fieldml-java2.
Details are at  
http://code.google.com/p/fieldml-java2/source/detail?r=472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5


Line-by-line comments:

File: /trunk/data/FieldmlTest.xml  
(r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5)
===============================================================================

Line 15:     <EnsembleDomain baseDomain="test_mesh.domain.elements"  
name="test_mesh.domain.elements">
-------------------------------------------------------------------------------
Please explain the meaning of using the same domain as the base domain and  
as the domain being declared."

File: /trunk/src/fieldml/region/WorldRegion.java  
(r7970cbd97420a00323fec528369fce4738d460c3)
===============================================================================

Line 3: public class WorldRegion
-------------------------------------------------------------------------------
WorldRegion does not need to be its own subclass.  Rather, just instantiate  
a region from a factory method of the Region class.

This is similar to the comment made about 2 weeks ago for Library: Library  
also does not need to be a sub-class of Region.



Respond to these comments at  
http://code.google.com/p/fieldml-java2/source/detail?r=472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings