[FieldML-automated1] Comment on revision r896ca1f74c732461f1682e36c743e877b8afb416 in fieldml-java2
Status: Beta
Brought to you by:
richardchr
From: <fie...@go...> - 2010-02-12 02:21:54
|
richardchristie commented on revision r896ca1f74c732461f1682e36c743e877b8afb416 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=896ca1f74c732461f1682e36c743e877b8afb416 Line-by-line comments: File: /trunk/src/fieldml/region/Region.java (r896ca1f74c732461f1682e36c743e877b8afb416) =============================================================================== Line 35: private static final Region library; ------------------------------------------------------------------------------- Should move creation of library region and its contents to separate utility module so Region.java can focus on actual region API (appendChild regions etc.) [Also need to finalise how each region is connected to library; are there multiple libraries? Is there one library region with sub regions (e.g. with URL names) for sub-libraries?] Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=896ca1f74c732461f1682e36c743e877b8afb416 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |