[FieldML-automated1] Comment on revision rb8d54ebf0a19b8c494022fb8fd0a9511cf248a93 in fieldml-java2

[<fie...@go...>]

r.brit...@auckland.ac.nz commented on revision  
rb8d54ebf0a19b8c494022fb8fd0a9511cf248a93 in project fieldml-java2.
Details are at  
http://code.google.com/p/fieldml-java2/source/detail?r=b8d54ebf0a19b8c494022fb8fd0a9511cf248a93


Line-by-line comments:

File: /trunk/data/BicubicHermiteTest.xml  
(r0468aa218b219403ca376f7fcdacb4f3d5fe4a09)
===============================================================================

Line 203:   <ContinuousParameters defaultValue="[1.0, 1.0, 1.0, 1.0]"  
name="test_mesh.cubic_hermite_scaling"  
valueDomain="library.bicubic_hermite.scaling">
-------------------------------------------------------------------------------
Rather than an attribute for the default value, it would be better to use  
something consistent with the way each of the "entries" are done, i.e.
<Default>
   <ContinuousDomainValue>
         <values>1.0  1.0  1.0  1.0  </values>
   </ContinuousDomainValue>
</Default>


Line 415:       <BicubicHermiteQuadEvaluator  
dofs="test_mesh.bicubic_parameters.z"  
dofScaling="test_mesh.cubic_hermite_scaling"  
dofIndexes="test_mesh.quad_nodes" name="hermite_quad" />
-------------------------------------------------------------------------------
We don't want tags as specific as this.
Rather, something like:
<Evaluator definition="library.BicubicHermiteQuadEvaluator" dofs= ... />

Respond to these comments at  
http://code.google.com/p/fieldml-java2/source/detail?r=b8d54ebf0a19b8c494022fb8fd0a9511cf248a93
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings