[FieldML-automated1] Comment on revision r0cc1faa2daebbb4c1f6eccc8eb87aa3a6908ab76 in fieldml-java2
Status: Beta
Brought to you by:
richardchr
From: <fie...@go...> - 2009-11-19 01:19:14
|
r.brit...@auckland.ac.nz commented on revision r0cc1faa2daebbb4c1f6eccc8eb87aa3a6908ab76 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=0cc1faa2daebbb4c1f6eccc8eb87aa3a6908ab76 Line-by-line comments: File: /trunk/src/fieldml/value/DomainValue.java (r43301baffdcdfb5c40e234b3023db91219296c2f) =============================================================================== Line 6: public abstract class DomainValue<D extends Domain> ------------------------------------------------------------------------------- Doesn't seem much point using a generic here. Just make the type of the domain attribute be "Domain". Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=0cc1faa2daebbb4c1f6eccc8eb87aa3a6908ab76 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |