Thread: [Ficl-developers] hello:)
Brought to you by:
jsadler
From: Toomas S. <ts...@me...> - 2016-07-23 11:38:48
|
hi! This certainly is a bit of surprise to see my subscribe request being accepted after that much of time:) I already thought its all dead now, glad to see it certainly is not true:) Just want to note for starters, I have been working on port of freebsd loader for illumos family of operating systems, and part of the work, I have integrated ficl 4 to my port of loader. Of course this also did mean some amount of work to make 4.1.0 actually working;) For time being the ficl bits in project can be browsed at https://github.com/tsoome/illumos-gate/tree/loader/usr/src/common/ficl, if there is any interest, I can put together patches for upstreaming, just at the moment my focus is on other issues related my project. rgds, toomas |
From: Toomas S. <ts...@me...> - 2016-07-25 18:54:56
|
> On 25. juuli 2016, at 21:30, Marcin Cieslak <sa...@sa...> wrote: > > On Sat, 23 Jul 2016, Toomas Soome wrote: > >> >> hi! >> >> This certainly is a bit of surprise to see my subscribe request being accepted after that much of time:) I already thought its all dead now, glad to see it certainly is not true:) >> >> Just want to note for starters, I have been working on port of freebsd >> loader for illumos family of operating systems, and part of the work, >> I have integrated ficl 4 to my port of loader. Of course this also did >> mean some amount of work to make 4.1.0 actually working;) >> >> For time being the ficl bits in project can be browsed at https://github.com/tsoome/illumos-gate/tree/loader/usr/src/common/ficl, if there is any interest, I can put together patches for upstreaming, just at the moment my focus is on other issues related my project. > > This is great! I have fixed 4.1.0 breakage with Windows and > also made more 64-bit changes. > > I have uploaded it here: > > https://github.com/forthinspired/ficl > > I hve sent you the invitation to join the team so we can > integrate your changes. > > Good to see the work going on! > > Marcin ok, I’ll try to find some time to review and compare in coming days… will see how my time will go. I assume you have also reviewed freebsd patches for 64bit build? They have done some just to make it build, but setjmp/pick issues are still there for them… btw, I also did replace lzjb with lz4 for 2 reasons - one is that lz4 does a bit better work, and for second, as zfs does have lz4, it means I can share the same uncompress and save some pages of precious memory;) well, the last bit wont really concern normal userspace interpreter. rgds, toomas |
From: Marcin C. <sa...@sa...> - 2016-07-25 19:47:22
|
On Mon, 25 Jul 2016, Toomas Soome wrote: > ok, I’ll try to find some time to review and compare in coming > days… will see how my time will go. I assume you have also reviewed > freebsd patches for 64bit build? They have done some just to make it > build, but setjmp/pick issues are still there for them… Hm, now as I come to it: last time I checked FreeBSD boot loader was based on ficl 3, and the current master is ficl 4, which has switched to a switch-threaded model. I have fixed lost 64 bit registers by rearranging macros with https://github.com/forthinspired/ficl/commit/f8c09048b6ec60f74932aac87d93cac527ec61fa > btw, I also did replace lzjb with lz4 for 2 reasons - one is that > lz4 does a bit better work, and for second, as zfs does have lz4, it > means I can share the same uncompress and save some pages of precious > memory;) well, the last bit wont really concern normal userspace > interpreter. I think that the pure ficl code does not contain anything to do with a compression, I believe it is a FreeBSD-related change. (By the way I am using FreeBSD every day) Marcin |
From: Marcin C. <sa...@sa...> - 2016-07-25 18:59:14
|
On Sat, 23 Jul 2016, Toomas Soome wrote: > > hi! > > This certainly is a bit of surprise to see my subscribe request being accepted after that much of time:) I already thought its all dead now, glad to see it certainly is not true:) > > Just want to note for starters, I have been working on port of freebsd > loader for illumos family of operating systems, and part of the work, > I have integrated ficl 4 to my port of loader. Of course this also did > mean some amount of work to make 4.1.0 actually working;) > > For time being the ficl bits in project can be browsed at https://github.com/tsoome/illumos-gate/tree/loader/usr/src/common/ficl, if there is any interest, I can put together patches for upstreaming, just at the moment my focus is on other issues related my project. This is great! I have fixed 4.1.0 breakage with Windows and also made more 64-bit changes. I have uploaded it here: https://github.com/forthinspired/ficl I hve sent you the invitation to join the team so we can integrate your changes. Good to see the work going on! Marcin |
From: Alex M. <cal...@gm...> - 2016-07-26 01:56:58
|
Hi! I haven't used Ficl in a few years, but I did come across a couple of bugs I've wanted to bring to someone's attention, so I've compared the 4.1.0 Ficl copy I used to Toomas's and Marcin's versions. (1) PICK - John Sadler's Ficl treats the stack as "xu ... x1 u" (no x0), while the DPANS94 says it should be "xu ... x1 x0 u". Toomas appears to have fixed it in vm.c (ficlInstructionPick case); Marcin still has John's original code. I always figured PICK was a common instruction, so I was surprised that Johbn never noticed the bug. (2) FILE-POSITION and FILE-SIZE - should return a double-cell integer according to DPANS94. However, ficlPrimitiveFilePosition() and ficlPrimitiveFileSize() in fileaccess.c use ficlStackPushInteger() to push a single-cell result onto the stack. This is true in all three versions of Ficl (John, Toomas, and Marcin). Since sometime back in the 2000s, I've had odd results with Ficl on various platforms from the Nintendo DS to Windows (98!) to Linux. Turning off all compiler optimization helped in some cases. Since my work didn't depend on Ficl (and the only Forth program I've written is a web server using network extensions to Ficl), I didn't dig too deeply into the strange behavior I was seeing and, as a result, I've never quite trusted Ficl. I'm glad to see you two are actively working on it! - Alex |
From: Toomas S. <ts...@me...> - 2016-07-25 20:10:04
|
> On 25. juuli 2016, at 23:02, Marcin Cieslak <sa...@sa...> wrote: > > On Mon, 25 Jul 2016, Toomas Soome wrote: > >> >>> On 25. juuli 2016, at 22:47, Marcin Cieslak <sa...@sa...> wrote: >>> >>> On Mon, 25 Jul 2016, Toomas Soome wrote: >>> >>>> ok, I’ll try to find some time to review and compare in coming >>>> days… will see how my time will go. I assume you have also reviewed >>>> freebsd patches for 64bit build? They have done some just to make it >>>> build, but setjmp/pick issues are still there for them… >>> >>> Hm, now as I come to it: last time I checked FreeBSD boot loader >>> was based on ficl 3, and the current master is ficl 4, which >>> has switched to a switch-threaded model. >> >> >> yes, its still is based on v3, there have been few attempts to >> switch to 4, but not completed. And of course, in loader it is used >> single threaded still:) They do have ficl4 as userspace app tho, but >> unfortunately, pretty broken;) > > Shall we revive ficl3 branches in the repository then? > > Marcin I don’t think there is need for that;) for time being they can live, and since I already have working ficl4, I can eventually push it to fbsd as well - since they have [had] some people working about it, I did not want to spoil their efforts, just gave some hints what to look for:) rgds, toomas |