Menu

#17 ficlDictionaryLock in ficlDictionaryLookup

open
nobody
crash & die (5)
5
2013-01-23
2011-12-14
No

I think the second ficlDictionaryLock() in ficlDictionaryLookup() in dictionary.c in both 4.0.31 and 4.1.0 should be FICL_FALSE instead of FICL_TRUE, so that the lock/unlock brackets correctly (and is consistent with its use elsewhere in the system). Otherwise, when using a real mutex and when FICL_MULTITHREAD is enabled it will eventually hang, either immediately (deadlock if the mutex doesn't implement recursion) or when another thread tries to do a ficlDistionaryLookup().

Discussion


Log in to post a comment.