From: Takashi S. <o-t...@sa...> - 2014-03-10 04:13:55
|
(Mar 10 2014 05:48), Clemens Ladisch wrote: > This is a 32-bit value. OK. Is it OK to use an assignment conversion here? Like: for (f = 0; f < frames; f++) { + buffer[s->pcm_channels + 1] = 0x00; > snd_rawmidi_transmit() will not write an unsused byte, and in any > case, zero can be a valid MIDI data byte. OK. The line is needless. > The buffer pointer must be increased even when there is no active port. Exactly. I confirm M-Audio Ozonic (opens two MIDI ports) receives wrong sequence of MIDI data because of this bug... > fw_iso_context_create() can return an error code, but for s->pcm, > all the IS_ERR stuff is not necessary. This should be a plain NULL > check. OK. Thanks Takashi Sakamoto o-t...@sa... |