Re: [FFADO-devel] Patching out external libraries?

[Orcan O. <oge...@gm...>]

On Mon, Jul 12, 2010 at 11:55 AM, Arnold Krille wrote:
> Hi,
>
> On Monday 12 July 2010 16:53:34 Adrian Knoth wrote:
>> On 07/10/10 10:41, Orcan Ogetbil wrote:
>> > I am packaging ffado for Fedora, and I realized that you are linking
>> > external libraries libconfig and dbus statically.
>> > Fedora does not normally allow linkage to static copies of libraries.
>> Same for Debian (I do the Debian packaging)
>> > Are these two libraries (libconfig and dbus) forked from their
>> > upstreams, or is it safe to patch them out and link to the system
>> > copies dynamically?
>> Patch them out. Have you already started? I just spent some minutes on
>> this issue and will hopefully come up with a clean solution that's save
>> to be applied.
>>
>> I suggest to entirely get rid of these copies. Libconfig was easy, dbus
>> seems a little harder, the generated glue code looks different and fails
>> to compile. Let's see...
>

The patch is good, except that since the dbus support is optional, the line
+        'dbus-c++-1' : '0',
should probably go to the "Optional pkg-config" area, around line 285.

> While I don't mind patching out libconfig, afaik the dbus++ stuff is (or was at
> that time) supposed to be copied into projects. Updating it to the newest
> version is on the todo-list. And will be super-seeded if we make it obsolete.
> If external linking to dbus++ is supported nowadays, I am all for ditching the
> external/-stuff completely.
>

I just verified that dbus-c++ is being shipped by Fedora, Debian,
OpenSuse, Mandriva, Ubuntu, and Archlinux. It is in review on Gentoo.
So I believe that it is safe to drop the bundled copy of the library.

However we need to add a check to scons  for the xml2cpp executable in
the proposed patch, as it might be distributed separately from the
package that contains the dbus-c++ pkgconfig file and headers.

Orcan