[FFADO-svn] r1234 - in trunk/libffado: external/dbus/src external/dbus/tools src/bebob src/bebob/focusrite src/bebob/terratec src/dice src/fireworks src/fireworks/efc src/libavc src/libavc/descriptors src/libavc/general src/libieee1394 src/libstreaming/amdtp src/libstreaming/motu src/libutil src/motu support/firmware tests tests/systemtests

[<tr...@ff...>]

Author: holin
Date: 2008-05-29 01:24:21 -0700 (Thu, 29 May 2008)
New Revision: 1234

Modified:
   trunk/libffado/external/dbus/src/message.cpp
   trunk/libffado/external/dbus/src/object.cpp
   trunk/libffado/external/dbus/src/types.cpp
   trunk/libffado/external/dbus/tools/xml2cpp.cpp
   trunk/libffado/src/bebob/bebob_avdevice.cpp
   trunk/libffado/src/bebob/bebob_dl_mgr.cpp
   trunk/libffado/src/bebob/focusrite/focusrite_saffirepro.cpp
   trunk/libffado/src/bebob/terratec/terratec_device.cpp
   trunk/libffado/src/dice/dice_avdevice.cpp
   trunk/libffado/src/fireworks/efc/efc_cmd.cpp
   trunk/libffado/src/fireworks/efc/efc_cmd.h
   trunk/libffado/src/fireworks/fireworks_firmware.cpp
   trunk/libffado/src/libavc/avc_definitions.h
   trunk/libffado/src/libavc/descriptors/avc_descriptor.cpp
   trunk/libffado/src/libavc/descriptors/avc_descriptor_cmd.cpp
   trunk/libffado/src/libavc/general/avc_extended_plug_info.cpp
   trunk/libffado/src/libavc/general/avc_generic.cpp
   trunk/libffado/src/libieee1394/ARMHandler.cpp
   trunk/libffado/src/libieee1394/IsoHandlerManager.cpp
   trunk/libffado/src/libstreaming/amdtp/AmdtpTransmitStreamProcessor.cpp
   trunk/libffado/src/libstreaming/motu/MotuReceiveStreamProcessor.cpp
   trunk/libffado/src/libstreaming/motu/MotuTransmitStreamProcessor.cpp
   trunk/libffado/src/libutil/IpcRingBuffer.cpp
   trunk/libffado/src/libutil/TimestampedBuffer.cpp
   trunk/libffado/src/libutil/cmd_serialize.cpp
   trunk/libffado/src/libutil/serialize_libxml.cpp
   trunk/libffado/src/libutil/unittests.cpp
   trunk/libffado/src/motu/motu_avdevice.cpp
   trunk/libffado/support/firmware/bridgeco-downloader.cpp
   trunk/libffado/support/firmware/downloader.cpp
   trunk/libffado/support/firmware/fireworks-downloader.cpp
   trunk/libffado/tests/scan-devreg.cpp
   trunk/libffado/tests/systemtests/gen-loadpulses.cpp
   trunk/libffado/tests/systemtests/test-isorecv-1.cpp
   trunk/libffado/tests/systemtests/test-sysload.cpp
   trunk/libffado/tests/test-avccmd.cpp
   trunk/libffado/tests/test-echomixer.cpp
   trunk/libffado/tests/test-enhanced-mixer.cpp
   trunk/libffado/tests/test-messagequeue.cpp
Log:
fix gcc 4.3 compile errors and some warnings (largely from Adrian Knoth)


Modified: trunk/libffado/external/dbus/src/message.cpp
===================================================================
--- trunk/libffado/external/dbus/src/message.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/external/dbus/src/message.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -29,6 +29,8 @@
 #include "internalerror.h"
 #include "message_p.h"
 
+#include <cstdlib>
+
 using namespace DBus;
 
 /*

Modified: trunk/libffado/external/dbus/src/object.cpp
===================================================================
--- trunk/libffado/external/dbus/src/object.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/external/dbus/src/object.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -33,6 +33,8 @@
 #include "server_p.h"
 #include "connection_p.h"
 
+#include <cstring>
+
 using namespace DBus;
 
 Object::Object( Connection& conn, const Path& path, const char* service )

Modified: trunk/libffado/external/dbus/src/types.cpp
===================================================================
--- trunk/libffado/external/dbus/src/types.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/external/dbus/src/types.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -30,6 +30,8 @@
 #include "message_p.h"
 #include "internalerror.h"
 
+#include <cstdlib>
+
 using namespace DBus;
 
 Variant::Variant()

Modified: trunk/libffado/external/dbus/tools/xml2cpp.cpp
===================================================================
--- trunk/libffado/external/dbus/tools/xml2cpp.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/external/dbus/tools/xml2cpp.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -31,6 +31,8 @@
 #include <iostream>
 #include <fstream>
 #include <sstream>
+#include <cstdlib>
+#include <cstring>
 
 using namespace std;
 using namespace DBus;

Modified: trunk/libffado/src/bebob/bebob_avdevice.cpp
===================================================================
--- trunk/libffado/src/bebob/bebob_avdevice.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/bebob/bebob_avdevice.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -52,7 +52,8 @@
 #include <iostream>
 #include <sstream>
 #include <unistd.h>
-#include <stdlib.h>
+#include <cstdlib>
+#include <cstring>
 #include <sys/stat.h>
 
 using namespace AVC;

Modified: trunk/libffado/src/bebob/bebob_dl_mgr.cpp
===================================================================
--- trunk/libffado/src/bebob/bebob_dl_mgr.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/bebob/bebob_dl_mgr.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -34,6 +34,7 @@
 #include "libutil/ByteSwap.h"
 
 #include <cstdio>
+#include <cstring>
 
 namespace BeBoB {
     enum {

Modified: trunk/libffado/src/bebob/focusrite/focusrite_saffirepro.cpp
===================================================================
--- trunk/libffado/src/bebob/focusrite/focusrite_saffirepro.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/bebob/focusrite/focusrite_saffirepro.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -28,6 +28,7 @@
 #include "libutil/Time.h"
 
 #include "libutil/ByteSwap.h"
+#include <cstring>
 
 namespace BeBoB {
 namespace Focusrite {

Modified: trunk/libffado/src/bebob/terratec/terratec_device.cpp
===================================================================
--- trunk/libffado/src/bebob/terratec/terratec_device.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/bebob/terratec/terratec_device.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -125,7 +125,7 @@
 {
     uint8_t fb_extsync_value = getSelectorFBValue(8);
     uint8_t fb_syncsource_value = getSelectorFBValue(9);
-    return fb_extsync_value & 0x01 | (fb_syncsource_value << 1) & 0x01;
+    return (fb_extsync_value & 0x01) | ((fb_syncsource_value << 1) & 0x01);
 }
 
 } // namespace Terratec

Modified: trunk/libffado/src/dice/dice_avdevice.cpp
===================================================================
--- trunk/libffado/src/dice/dice_avdevice.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/dice/dice_avdevice.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -29,16 +29,17 @@
 
 #include "debugmodule/debugmodule.h"
 
-#include <string>
-#include <stdint.h>
-#include <assert.h>
 #include "libutil/ByteSwap.h"
 #include <libraw1394/csr.h>
 
+#include <stdint.h>
 #include <iostream>
 #include <sstream>
 
 #include <string>
+#include <cstring>
+#include <assert.h>
+
 using namespace std;
 
 namespace Dice {

Modified: trunk/libffado/src/fireworks/efc/efc_cmd.cpp
===================================================================
--- trunk/libffado/src/fireworks/efc/efc_cmd.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/fireworks/efc/efc_cmd.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -26,6 +26,7 @@
 
 #include "libutil/ByteSwap.h"
 #include <iostream>
+#include <cstring>
 
 using namespace std;
 

Modified: trunk/libffado/src/fireworks/efc/efc_cmd.h
===================================================================
--- trunk/libffado/src/fireworks/efc/efc_cmd.h	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/fireworks/efc/efc_cmd.h	2008-05-29 08:24:21 UTC (rev 1234)
@@ -196,7 +196,7 @@
         eERV_Unspecified    = 0xFFFFFFFFL,
     };
 
-    typedef struct efc_header
+    struct efc_header
     {
         uint32_t    version;
         uint32_t    seqnum;

Modified: trunk/libffado/src/fireworks/fireworks_firmware.cpp
===================================================================
--- trunk/libffado/src/fireworks/fireworks_firmware.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/fireworks/fireworks_firmware.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -34,6 +34,7 @@
 #include <sstream>
 #include <iostream>
 #include <fstream>
+#include <cstring>
 
 #define ECHO_FLASH_ERASE_TIMEOUT_MILLISECS 2000
 

Modified: trunk/libffado/src/libavc/avc_definitions.h
===================================================================
--- trunk/libffado/src/libavc/avc_definitions.h	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libavc/avc_definitions.h	2008-05-29 08:24:21 UTC (rev 1234)
@@ -25,6 +25,8 @@
 #define AVCDEFINITIONS_H
 
 #include <libavc1394/avc1394.h>
+#include <cstring>
+#include <cstdlib>
 #include <ostream>
 
 

Modified: trunk/libffado/src/libavc/descriptors/avc_descriptor.cpp
===================================================================
--- trunk/libffado/src/libavc/descriptors/avc_descriptor.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libavc/descriptors/avc_descriptor.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -31,6 +31,8 @@
 #include "libieee1394/ieee1394service.h"
 #include "libieee1394/configrom.h"
 
+#include <cstring>
+
 namespace AVC {
 
 AVCDescriptorSpecifier::AVCDescriptorSpecifier( enum EType type )

Modified: trunk/libffado/src/libavc/descriptors/avc_descriptor_cmd.cpp
===================================================================
--- trunk/libffado/src/libavc/descriptors/avc_descriptor_cmd.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libavc/descriptors/avc_descriptor_cmd.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -29,6 +29,7 @@
 
 #include "libutil/ByteSwap.h"
 #include <iostream>
+#include <cstring>
 
 using namespace std;
 

Modified: trunk/libffado/src/libavc/general/avc_extended_plug_info.cpp
===================================================================
--- trunk/libffado/src/libavc/general/avc_extended_plug_info.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libavc/general/avc_extended_plug_info.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -27,6 +27,8 @@
 
 #include "libutil/ByteSwap.h"
 #include <iostream>
+#include <cstdlib>
+#include <cstring>
 
 using namespace std;
 

Modified: trunk/libffado/src/libavc/general/avc_generic.cpp
===================================================================
--- trunk/libffado/src/libavc/general/avc_generic.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libavc/general/avc_generic.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -31,6 +31,9 @@
 
 #include "libutil/ByteSwap.h"
 
+#include <cstring>
+#include <cstdlib>
+
 #define DEBUG_EXTRA_VERBOSE 5
 
 

Modified: trunk/libffado/src/libieee1394/ARMHandler.cpp
===================================================================
--- trunk/libffado/src/libieee1394/ARMHandler.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libieee1394/ARMHandler.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -21,6 +21,9 @@
  *
  */
 
+#include <cstring>
+#include <cstdlib>
+
 #include "ARMHandler.h"
 
 IMPL_DEBUG_MODULE( ARMHandler, ARMHandler, DEBUG_LEVEL_NORMAL);

Modified: trunk/libffado/src/libieee1394/IsoHandlerManager.cpp
===================================================================
--- trunk/libffado/src/libieee1394/IsoHandlerManager.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libieee1394/IsoHandlerManager.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -31,6 +31,7 @@
 #include "libutil/SystemTimeSource.h"
 #include "libutil/Watchdog.h"
 
+#include <cstring>
 #include <assert.h>
 
 IMPL_DEBUG_MODULE( IsoHandlerManager, IsoHandlerManager, DEBUG_LEVEL_NORMAL );

Modified: trunk/libffado/src/libstreaming/amdtp/AmdtpTransmitStreamProcessor.cpp
===================================================================
--- trunk/libffado/src/libstreaming/amdtp/AmdtpTransmitStreamProcessor.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libstreaming/amdtp/AmdtpTransmitStreamProcessor.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -36,6 +36,7 @@
 
 #include "libutil/ByteSwap.h"
 #include <assert.h>
+#include <cstring>
 
 #define AMDTP_FLOAT_MULTIPLIER 2147483392.0
 

Modified: trunk/libffado/src/libstreaming/motu/MotuReceiveStreamProcessor.cpp
===================================================================
--- trunk/libffado/src/libstreaming/motu/MotuReceiveStreamProcessor.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libstreaming/motu/MotuReceiveStreamProcessor.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -34,8 +34,10 @@
 #include "libieee1394/IsoHandlerManager.h"
 #include "libieee1394/cycletimer.h"
 
+#include "libutil/ByteSwap.h"
+
+#include <cstring>
 #include <math.h>
-#include "libutil/ByteSwap.h"
 #include <assert.h>
 
 /* Provide more intuitive access to GCC's branch predition built-ins */

Modified: trunk/libffado/src/libstreaming/motu/MotuTransmitStreamProcessor.cpp
===================================================================
--- trunk/libffado/src/libstreaming/motu/MotuTransmitStreamProcessor.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libstreaming/motu/MotuTransmitStreamProcessor.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -35,6 +35,8 @@
 #include "libieee1394/cycletimer.h"
 
 #include "libutil/ByteSwap.h"
+
+#include <cstring>
 #include <assert.h>
 
 // Set to 1 to enable the generation of a 1 kHz test tone in analog output 1.  Even with

Modified: trunk/libffado/src/libutil/IpcRingBuffer.cpp
===================================================================
--- trunk/libffado/src/libutil/IpcRingBuffer.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libutil/IpcRingBuffer.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -28,6 +28,8 @@
 #include "PosixMutex.h"
 #include "Functors.h"
 
+#include <cstring>
+
 // FIXME: if we restrict the nb_blocks to a power of two, the overflows
 //        can be implemented using masks
 

Modified: trunk/libffado/src/libutil/TimestampedBuffer.cpp
===================================================================
--- trunk/libffado/src/libutil/TimestampedBuffer.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libutil/TimestampedBuffer.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -30,6 +30,8 @@
 #include "assert.h"
 #include "errno.h"
 
+#include <cstdlib>
+#include <cstring>
 
 #define DLL_PI        (3.141592653589793238)
 #define DLL_SQRT2     (1.414213562373095049)

Modified: trunk/libffado/src/libutil/cmd_serialize.cpp
===================================================================
--- trunk/libffado/src/libutil/cmd_serialize.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libutil/cmd_serialize.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -25,6 +25,8 @@
 
 #include <iostream>
 #include <iomanip>
+#include <cstdlib>
+#include <cstring>
 
 #include "libutil/ByteSwap.h"
 

Modified: trunk/libffado/src/libutil/serialize_libxml.cpp
===================================================================
--- trunk/libffado/src/libutil/serialize_libxml.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libutil/serialize_libxml.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -24,6 +24,9 @@
 
 #include "serialize.h"
 
+#include <cstring>
+#include <cstdlib>
+
 using namespace std;
 
 

Modified: trunk/libffado/src/libutil/unittests.cpp
===================================================================
--- trunk/libffado/src/libutil/unittests.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/libutil/unittests.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -27,6 +27,7 @@
 #include <libraw1394/raw1394.h>
 
 #include <stdio.h>
+#include <cstring>
 
 using namespace Util;
 

Modified: trunk/libffado/src/motu/motu_avdevice.cpp
===================================================================
--- trunk/libffado/src/motu/motu_avdevice.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/src/motu/motu_avdevice.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -1245,9 +1245,9 @@
     // optical port modes.  At this stage it's not completely understood
     // what the "Optical control" register does, so the values it's set to
     // are more or less "magic" numbers.
-    if (reg & MOTU_OPTICAL_IN_MODE_MASK != (MOTU_OPTICAL_MODE_ADAT<<8))
+    if ((reg & MOTU_OPTICAL_IN_MODE_MASK) != (MOTU_OPTICAL_MODE_ADAT<<8))
         opt_ctrl |= 0x00000080;
-    if (reg & MOTU_OPTICAL_OUT_MODE_MASK != (MOTU_OPTICAL_MODE_ADAT<<10))
+    if ((reg & MOTU_OPTICAL_OUT_MODE_MASK) != (MOTU_OPTICAL_MODE_ADAT<<10))
         opt_ctrl |= 0x00000040;
 
     if (mode & MOTU_DIR_IN) {

Modified: trunk/libffado/support/firmware/bridgeco-downloader.cpp
===================================================================
--- trunk/libffado/support/firmware/bridgeco-downloader.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/support/firmware/bridgeco-downloader.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -30,6 +30,8 @@
 #include "libieee1394/ieee1394service.h"
 
 #include <iostream>
+#include <cstdlib>
+#include <cstring>
 
 using namespace std;
 

Modified: trunk/libffado/support/firmware/downloader.cpp
===================================================================
--- trunk/libffado/support/firmware/downloader.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/support/firmware/downloader.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -30,9 +30,9 @@
 #include "debugmodule/debugmodule.h"
 
 #include <iostream>
+#include <cstdlib>
+#include <cstring>
 
-#include <stdlib.h>
-
 using namespace std;
 
 DECLARE_GLOBAL_DEBUG_MODULE;

Modified: trunk/libffado/support/firmware/fireworks-downloader.cpp
===================================================================
--- trunk/libffado/support/firmware/fireworks-downloader.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/support/firmware/fireworks-downloader.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -35,9 +35,9 @@
 #include "devicemanager.h"
 
 #include <iostream>
-
-#include <string.h>
 #include <string>
+#include <cstring>
+#include <cstdlib>
 
 #define MAGIC_THAT_SAYS_I_KNOW_WHAT_IM_DOING 0x001807198000LL
 

Modified: trunk/libffado/tests/scan-devreg.cpp
===================================================================
--- trunk/libffado/tests/scan-devreg.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/tests/scan-devreg.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -33,8 +33,9 @@
 #include "libutil/Time.h"
 
 #include <argp.h>
-#include <stdlib.h>
+#include <cstdlib>
 #include <iostream>
+#include <cstring>
 
 using namespace std;
 

Modified: trunk/libffado/tests/systemtests/gen-loadpulses.cpp
===================================================================
--- trunk/libffado/tests/systemtests/gen-loadpulses.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/tests/systemtests/gen-loadpulses.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -36,6 +36,7 @@
 
 #include "debugmodule/debugmodule.h"
 #include "realtimetools.h"
+#include <cstdlib>
 
 uint32_t count = 0;
 

Modified: trunk/libffado/tests/systemtests/test-isorecv-1.cpp
===================================================================
--- trunk/libffado/tests/systemtests/test-isorecv-1.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/tests/systemtests/test-isorecv-1.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -34,6 +34,7 @@
 
 #include "debugmodule/debugmodule.h"
 #include "realtimetools.h"
+#include <cstdlib>
 
 uint32_t count = 0;
 

Modified: trunk/libffado/tests/systemtests/test-sysload.cpp
===================================================================
--- trunk/libffado/tests/systemtests/test-sysload.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/tests/systemtests/test-sysload.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -36,6 +36,7 @@
 
 #include "debugmodule/debugmodule.h"
 #include "realtimetools.h"
+#include <cstdlib>
 
 uint32_t count = 0;
 

Modified: trunk/libffado/tests/test-avccmd.cpp
===================================================================
--- trunk/libffado/tests/test-avccmd.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/tests/test-avccmd.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -259,7 +259,7 @@
     
     bool tmpresult=true;
     nargs=0;
-    while(tmpresult=de.read(&args[nargs])) {
+    while((tmpresult=de.read(&args[nargs]))) {
         nargs++;
     }
     

Modified: trunk/libffado/tests/test-echomixer.cpp
===================================================================
--- trunk/libffado/tests/test-echomixer.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/tests/test-echomixer.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -39,8 +39,9 @@
 using namespace FireWorks;
 
 #include <argp.h>
-#include <stdlib.h>
 #include <iostream>
+#include <cstdlib>
+#include <cstring>
 
 using namespace std;
 using namespace AVC;

Modified: trunk/libffado/tests/test-enhanced-mixer.cpp
===================================================================
--- trunk/libffado/tests/test-enhanced-mixer.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/tests/test-enhanced-mixer.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -25,6 +25,8 @@
 #include "libutil/cmd_serialize.h"
 
 #include "libieee1394/ieee1394service.h"
+#include <cstdlib>
+#include <cstring>
 
 using namespace AVC;
 

Modified: trunk/libffado/tests/test-messagequeue.cpp
===================================================================
--- trunk/libffado/tests/test-messagequeue.cpp	2008-05-28 13:07:06 UTC (rev 1233)
+++ trunk/libffado/tests/test-messagequeue.cpp	2008-05-29 08:24:21 UTC (rev 1234)
@@ -32,6 +32,7 @@
 #include <signal.h>
 
 #include <semaphore.h>
+#include <cstring>
 
 using namespace Util;