Re: [Fetchmail-users] ANNOUNCE: The 6.5.0.beta9 snapshot of fetchmail is available

[Matthias A. <mat...@gm...>]

Am 12.01.23 um 17:07 schrieb Christian Ebert:
> Hi Matthias,
>
> * Matthias Andree on Friday, January 06, 2023 at 22:09:32 +0100:
>> The 6.5.0.beta9 release of fetchmail is now available at the usual
>> locations,
>
> On MacOS 12.6.2 I had to revert getopt.h to beta8 state:
>
> --- getopt.h.orig       2023-01-12 15:53:05.000000000 +0000
> +++ getopt.h    2023-01-12 15:53:31.000000000 +0000
> @@ -101,7 +101,7 @@
>     errors, only prototype getopt for the GNU C library.  */
>  extern int getopt (int argc, char *const *argv, const char *shortopts);
>  #else /* not __GNU_LIBRARY__ */
> -extern int getopt (void);
> +extern int getopt ();

Hi Christian,

thanks for the report. My thinking is "Uh, right. Sorry. I know better."

I was fixing compiler warnings quickly, and I was so caught up in C++
implementation thinking where () indeed means (void) that I didn't
notice this was C, and getopt() without arguments does not make sense
either without looking at the #ifdef context and cleaning it up properly.

So, since fetchmail 6.5 will expect some degree of standards
conformance, and unistd.h has been required to provide a getopt()
declaration since before the dawn of ages, I will just strip this and
the #ifdef stuff. This should be fixed in git 6b8fb508. Can you please
try if that version works for you, or else, download from Gitlab, and
see if you can still compile it on MacOS? Link:
https://gitlab.com/fetchmail/fetchmail/-/raw/legacy_6x/getopt.h?inline=false

Thanks in advance.

Cheers,
Matthias