Re: [fetchmail-devel] [PATCH] fetchmail fix coordination and future planning

[Matthias A. <mat...@gm...>]

Am 04.05.2011 12:50, schrieb Sunil Shetye:
> ----- Original Message -----
> 
>> And it went unnoticed possibly because you use different compiler flags
>> (I routinely compile with -pedantic -Wall and often also with -Wextra or
>> -W, and I routinely also try Intel C++ and Clang, and I take care to
>> have at least -O1 or usually -O2 set -- my current computer is fast
>> enough and compiles fetchmail (after configure) in < 2.5 s real time.)
> 
> Is there a way of enabling those CFLAGS flags as well as the configure flags by default? Every time I switch machines and checkout fetchmail again (which is rare), I seem to miss out setting the same set of flags again.

Hm. These are compiler-specific, so we'd have to test explicitly.

> I have enabled the warnings now. I have also added -Wformat=2 and got some warnings.
> 
> Attached is a minor patch to fix those warnings.

Good catch, although I have the nasty feeling I've fixed similar bugs in
other .c files before. I wonder how these slipped past my attention...