Re: [fetchmail-devel] fetchmail fix coordination and future planning

[Matthias A. <mat...@gm...>]

On 04.05.2011 08:46, Sunil Shetye replied:

>>     Fixup: remove unused variables.
> 
> How did I miss that?

Hi Sunil,

As fetchmail 6.3.X is C89-style, variable declarations are far away from
their use, so missing "first/last" was easy. Add to that the humongous
text length of some code parts...

And it went unnoticed possibly because you use different compiler flags
(I routinely compile with -pedantic -Wall and often also with -Wextra or
-W, and I routinely also try Intel C++ and Clang, and I take care to
have at least -O1 or usually -O2 set -- my current computer is fast
enough and compiles fetchmail (after configure) in < 2.5 s real time.)

> Thanks for the review.

Thanks for the counter-review.

Best regards
Matthias