Re: [fetchmail-devel] An actual patch

[Rainer W. <rwe...@ms...>]

"Matthias Andree" <mat...@gm...> writes:

[...]

> For reasons beyond me, --fastuidl 5 does not currently appear to work.
> Fetchmail pulls the whole UID list.
> Haven't checked yet if that's an artifact of your code.

Hmm ... 'works for me' (in daemon mode). 

>> NB: The Makefile.am change should probably be moved to the POP3
>> section of Makefile.am
>
> Move it to libfm_a_SOURCES=... - that lets the linker sort out if the
> uid_db code is needed.

Done. The modified code is meanwhile pulling mail for our customers
and so far, it seems that the relative amount of (processing) time
spent on dealing with POP3 UIDs has dropped from about 93.5% to about
35%. Provided the oprofile daemon doesn't crash overnight (appears to
be a hobby of it), I should have some (extrapolated) absolute numbers
tomorrow before noon. I will also reformat my section headings to
remove the consecutive asterisks and I would like to again dump the
documentation comments for the trivial subroutines[*] but apart from
that, I don't believe that there will be further non-trivial changes.

	[*] I've encountered too many cases of code which was moved to
	a different place and modified somewhat in order to accomplish
	a somewhat different function, but - of course - leaving all
	the original comments intact to put any trust in comments.