Re: [fetchmail-devel] fetchmail 6.3.15-beta1 beta release with "bad-header pass" feature

[Matthias A. <mat...@gm...>]

Am 25.02.2010 08:14, schrieb Frédéric Marchal:
> On Wednesday 24 February 2010, Matthias Andree wrote:
>> Am 24.02.2010 13:08, schrieb Frédéric Marchal:
>> > The localdomains option cannot be shortened as local as specified in the
>> > man page (that may not be new, I'm coming from 6.3.9).
>>
>> That's a good catch. The abbreviated form has never worked - according to
>> "git annotate", it was already broken when it was added by ESR on
>> 1997-01-09, however the fix is simple: change "local(domains)" in
>> rcfile_l.l to "local(domains)?" and recompile. You need flex installed.
> 
> I was using the short form with fetchmail 6.3.9. So, it was either not 
> complaining about the invalid option or it was working. I tend to believe it 
> is the latter as our mails were processed as expected and we had problems 
> before that option was added.

I think the parser misunderstood your rcfile, so it wouldn't complain.

If there was another list (such as aka) prior to the local option, that list
would have had two more tokens, namely the word "local" and the domain -- and
that may have been sufficient to set delivery apparently straight (while
fetchmail would have mapped multidrop users, which localdomains is actually
supposed to suppress).

> On the other hand, I don' t see any change in the source code between versions 
> 6.3.8 and 6.3.15 that could explain why the option ceased to work or why it 
> would start complaining...

And I don't see how it could have worked as advertised. The lexer used to emits
a LOCALDOMAINS token only on "localdomains", but not on "local". I guess it
would have returned local as a STRING, and then the domain also as a STRING.

HTH

-- 
Matthias Andree