Re: [fetchmail-devel] fetchmail and mapi II

[mojmir s. <moj...@2k...>]

hello everyone,

first i'd like to note that i am not a mapi specialist.. or anything close to
that. i simply have to live with this exchange and not want to use outlook.


> > 3. missing mapi_session* argument
> > 	affected functions are mapi_init, smtp_address
> > 	(calls OpenMsgStore, GetGALTable)
> > 	i had to introduce static global variable for that.

you can find a patch in the attachment. this way it at least compiles and runs.

the things is: if i use s_mapi_session everywhere it stops to work properly in
mapi_getauth (MapiLogonProvider creates another session and if the
s_mapi_session passed as arg, it crashes later in ProcessNetworkProfile)

so the s_mapi_session is shared only between mapi_init and smptp_address for a
moment.

> > 4. buffer overflows
> > 	affected functions get_base64_attachment, octool_get_stream
> > 	perhaps all these memcpys should be reviewed

i will toy with this few days until i figure what the correct form should be. 

as a hotfix i simply allocated lot of memory and removed the loop that did
nothing. i assume you do not want that kind of solution (and neither do i..
in long term)

> > 6. \r characters and = spread all around in mail body
> What is this quoted_printable_encode part doing wrong? Could you provide
> your solution to (6)? Perhaps we can build a full solution on top of yours.

errr.. do not overestimate me... i simply removed the code that did not
suited me ;)

	for example: what is this supposed to do? 8->7 bit?
			if (is_safe_char(ch))
				line[line_count++] = ch;
			else {  
				line[line_count++] = '=';
				line[line_count++] = hex[(ch >> 4) & 15];
				line[line_count++] = hex[ch & 15];
			}
	if yes i wonder why mutt (set noallow_8bit) displays that incorrectly.

	and then there are these line[line_count++] = '\r';
	which are later visible in mutt.

	sincerely, i have no idea what proper solution should look like. 

there are more problems:
	- fetchmail modifies the "From: " header
	- fetchmail seems to drop any list-id and in-reply-to fields (and perhaps
	  other fields). this makes mailing lists (and threading) a little bit
	  uncomfortable

best regards and thanks for your replies,
mojmir