Re: [fetchmail-devel] fetchmail-6.3.8 portability patches

[Matthias A. <mat...@gm...>]

Am Mittwoch, den 31.10.2007, 11:41 -0500 schrieb Peter O'Gorman:

> We built fetchmail on a number of platforms and had few issues, thank
> you!
> 
> Include the typedef for int16 in the #ifndef _AIX in smbencrypt.c
> 
> Correct check for u_int32_t in configure.ac (seems to be typedef'ed in
> namser.h on some platforms.)
> 
> In configure.ac change all CPFLAGS to CPPFLAGS, CEFLAGS to CFLAGS and
> LDEFLAGS to LDFLAGS otherwise the results of some tests (additional -L
> and -I flags) do not get used for later tests causing incorrect
> configure results. Makefile.am was also changed to reflect this.
> 
> m4/gethostbyname_r.m4 does AC_TRY_COMPILE, which unfortunately can
> pass even if there is no gethostbyname_r. Changed to AC_TRY_LINK.
> 
>  __attribute__ ((unused)) is a gccism, removed from
> libesmtp/gethostbyname.c.
> 
> In KAME/getnameinfo.c it's best to use the correct argument to
> inet_ntoa.
> 
> Patch attached, sorry if these issues have already been fixed in the
> development sources.

Hi Peter,

it was a long time since you wrote that mail, and I finally got around
to looking at your patch and merging it, it will be part of fetchmail
6.3.9 - portability work is always very welcome and much appreciated.

I had to add a NULL define for FreeBSD 6.2 to run the get*info() test
properly (it appears sys/types.h is insufficient on that OS), and I have
also needed to add an AC_DEFINE for HAVE_GETNAMEINFO).

Thanks a lot for your patch.

Best regards
Matthias