Re: [fetchmail-devel] STARTTLS for ODMR

[Matthias A. <mat...@gm...>]

Jakob Hirsch schrieb:

> In general, you are right, of course. But the code is merely 60 lines 
> and contains no heavy logic. The only SSL-specific stuff is a single 
> call to SSLOpen(), the rest is more or less the same, with only some 
> protocol specifics, esp. the rereading of the server's capabilities. I'm 
> not sure if creating a new function that has to fulfill all the needs is 
> that good, but I didn't look that close at the code. pop3.c contains 
> just the same code, btw.

Apparently my attempt to subliminally delegate this part of the cleanup
failed, but at least I tried. :-)

>> If it's still possible to add it manually, I don't mind, although I
>> wonder if that makes the patch suitable for inclusion into 6.3.
> 
> Sure, "fetchdomains" works as before. This is only the first hunk of the 
> patch, so it could be easily removed.

It's an incompatible change, so if we can find a configuration option to
suppress adding that, I'm more comfortable with that because it avoids
another "incompatible change" changelog entry :-)

>>> - What's with the formatting in odmr.c?? Mixed spaces and tabs, that's
>>> quite horrible... if you don't mind, I'll clean that up (to whatever the
>>> preferred format is).
>> Well, my canonical style (I'm using vim) is an indentation width of 4
>> columns per level and using a tabwidth of 8, I.e. it's zero or more tabs
> 
> Oh. Ok. Any reason for that? (Not that I want to start a discussion on 
> tabs vs. spaces.)
> And how do you tell vim (which I happen to use, too) to use this style?

Historical practice with unknown origin. I don't even know if
smartindent/cindent/indentexpr would be even easier to use (-8

I think the crucial vim magic is the first 'set' line below
(tabstop=8 is the default in my vim 7):

" --------------------------------------------------------
" ~/.vimrc excerpt

" crucial part:
set shiftwidth=4 softtabstop=4 tabstop=8

" And beyond that, I use - among others:
set nocompatible
set bs=2 fo=cqrt ls=2 shm=at tw=72 ww=<,>,h,l
set showmatch ruler
set grepprg=grep\ -nH\ $*
set hidden
set backup
set autoindent
set iskeyword+=:

filetype plugin on
filetype indent on

if has("syntax")
        so ${VIMRUNTIME}/syntax/syntax.vim
endif
" end of ~/.vimrc excerpt
" --------------------------------------------------------