Re: [fetchmail-devel] [PATCHes] Misc. cleanups

[Matthias A. <mat...@gm...>]

Miloslav Trmac <mi...@re...> writes:

> - fetchmail-signed.patch: Avoid implicit conversions between
>   char * and unsigned char *; they are not defined by ISO C and gcc
>   currently warns about them.  Most places were changed to use "char *",
>   or "void *" where general binary data is handled.

The report.c patch appears wrong, it has to be n >= 0 rather than n < 0,
and needs to be changed in both branches of each of the two #ifdef.

What is the reason for the (int32) cast in kerberos.c near line 220?

> - fetchmail-comparisons.patch: Change variable types or add explicit
>   casts to make all casts use types with consistent type signedness,
>   for clarity
> - fetchmail-clean.patch: Remove or (void) out unused parameters, avoid
>   assignments directly in if ().
>
> - fetchmail-lmtp.patch: A real bug detected by the compiler, "," has
>   lower priority than "||".

Other than that, I merged your patches.

Thanks a lot.

-- 
Matthias Andree