Re: [fetchmail-devel] [PATCHes] Misc. cleanups

[Matthias A. <mat...@gm...>]

Nico Golde <ni...@ng...> writes:

> Hi,
> * Miloslav Trmac <mi...@re...> [2006-03-12 01:25]:
> [...] 
>> -    if (retval = krb5_cc_get_principal(context, ccdef, &client)) {
>> +    if ((retval = krb5_cc_get_principal(context, ccdef, &client)) != 0) {
>
> [...] 
> What is your point here? I can't see a real reason to do 
> this because its the same.

Yes, but it causes GCC warnings and who says it shouldn't have been
retval == ... ? I'll see if I take Mirek's patch or just write

       retval = krb5..;
       if (retval) { ... }

when reviewing all of it. 

BTW, Mirek, thanks for your detail work.

The warnings have been annoying me for ages but I didn't have the time
to fix them.

-- 
Matthias Andree