Re: [fetchmail-devel] [PATCH] close smtp socket early

[Matthias A. <mat...@gm...>]

Well, this has been sitting in my queue for some reason.

Sunil Shetye <sh...@bo...> wrote four weeks ago:

> The attached patch fixes the following bugs:
>
> 1. fetchmail should close smtp socket as soon as its work is done.
> This matters when fetchmail is polling multiple hosts and the smtp
> sockets just pile up till the end of the run. A SIGPIPE can also be
> triggered if there is a lot of time interval between the end of poll
> of the first mailserver and the end of run.

OK

> 2. PS_MAXFETCH is being treated as an error condition. It should be
> treated as a successful run instead.

OK

> 3. On reaching the fetchlimit, a negative count is shown of mails
> remaining on the server when fetchmail IDLEs (or repolls) atleast once
> with this configuration before reaching the fetchlimit:
>
> poll mailserver
>     protocol imap
>     fetchlimit 150
>     idle
>
> The line looks like this:
>
> fetchlimit 150 reached; -99 messages left on server mailserver account user

OK

> 4. stage should be set to STAGE_LOGOUT on a normal logout. Also, a new
> stage STAGE_PREAUTH has been added to handle the server greeting line
> (currently unused). stage is now an enum.

I would rather not merge this in its entirety for 6.3.1 - I promised not
to change fetchmail 6.3.X in such a way, and I don't feel like adding
dead code anyways.

> 5. The value of err is overwritten if there is a postconnect script or
> during normal logout. It should be preserved as far as possible.

OK

I've dumped the complete patch onto the trunk, but I've removed the int
to enum conversion of "stage" and the dead STAGE_PREAUTH from what I've
committed on the 6.3 branch.

-- 
Matthias Andree