Re: [fetchmail-devel] [PATCH] fix listener mode

[Matthias A. <mat...@gm...>]

Sunil Shetye <sh...@bo...> writes:

> Quoting from Matthias Andree's mail on Tue, Dec 13, 2005:
>> > [OFFTOPIC] While debugging this, I found a weird bug relating to this
>> > SMTP/LMTP mode. It seems that once fetchmail switches to LMTP mode,
>> > there is no going back to SMTP mode. Try this simple fetchmail
>> > command:
>> >
>> > $ fetchmail -v --smtphost /this/socket/is/down,localhost
>> >
>> > fetchmail sends LHLO to the localhost SMTP server. Note that SMTP
>> > cannot be forced as the user could be running this configuration:
>
> Here is a patch which fixes this issue. This basically removes the
> global smtp_mode variable and passes the desired mode in every smtp
> function.

Wow, that patch is huge.  I'll happily merge it or something similar
onto the trunk (cleanup is always good), but for 6.3.1 I'd prefer a
smaller patch, even if it means hacking the state structures in some
places (for instance, upon sending a bounce and completion of the bounce
function).

I wonder if bouncing messages is the right thing at all. There should be
no reason to ever bounce in singledrop mode, and multidrop mode should
also only bounce for unknown users (but actually, that's the task of the
upstream servers; catchall OTOH is not a good idea any more nowadays).

> You may compare the output of
>
> $ fetchmail -v --smtphost /this/socket/is/down,localhost
>
> before and after the patch.

-- 
Matthias Andree