Re: [fetchmail-devel] Re: RFC: Patch to fix Berlios Bug #5849

[Matthias A. <mat...@gm...>]

Sunil Shetye <sh...@bo...> writes:

> Quoting from Matthias Andree's mail on Tue, Dec 13, 2005:
>> Matthias Andree <mat...@gm...> writes:
>> > Joachim Feise reported that his smtphost setting is lost/ignored since
>> > 6.3.0. I could reproduce this.
>> > <http://developer.berlios.de/bugs/?func=detailbug&bug_id=5849&group_id=1824>
>> >
>> > However, I use neither LMTP nor multidrop, so I need help determining if
>> > the attached patch that I made is safe.
>> 
>> Hm. This is the same sink.c patch but without space changes and should
>> thus be easier to review. Please comment:
>
> Oops, my mistake.

Is it really?

> Yes, this patch is certainly required. This will also avoid an
> xfree/xstrdup on every mail. I would even recommend moving the
> declaration of parsed_host into the if block.
>
> [OFFTOPIC] While debugging this, I found a weird bug relating to this
> SMTP/LMTP mode. It seems that once fetchmail switches to LMTP mode,
> there is no going back to SMTP mode. Try this simple fetchmail
> command:
>
> $ fetchmail -v --smtphost /this/socket/is/down,localhost
>
> fetchmail sends LHLO to the localhost SMTP server. Note that SMTP
> cannot be forced as the user could be running this configuration:

Well, one thing that astonished me a bit is that on one hand the input
side is clearly encapsulated with object-oriented practices, while the
output side (SMTP/LMTP; MDA; BSMTP) is not nearly as clearly separated.
On the other hand, we use POP3 sibling "protocols" where a distinction
per "authentication" would be sufficient.

We certainly have some tasks ahead before fetchmail 7.0.0 some day - and
I wonder if we should talk to the compilers in C++ rather than C.

> $ fetchmail -v --lmtp --smtphost localhost/port,/this/socket/is/up
>
> where localhost is indeed meant to be an LMTP server.
>
> The situation gets worse if fetchmail sends a bounce message in
> between!

Sending bounce messages is a sore spot. AFAIR, no bounce messages are
ever sent if bogofilter is in MDA mode. MDA mode doesn't work for
multidrop, as you'll probably recall from past discussions over at
fetchmail-friends. I don't know about BSMTP restrictions.

-- 
Matthias Andree