[fetchmail-devel] Re: RFC: Patch to fix Berlios Bug #5849

[Sunil S. <sh...@bo...>]

Quoting from Matthias Andree's mail on Tue, Dec 13, 2005:
> Matthias Andree <mat...@gm...> writes:
> > Joachim Feise reported that his smtphost setting is lost/ignored since
> > 6.3.0. I could reproduce this.
> > <http://developer.berlios.de/bugs/?func=detailbug&bug_id=5849&group_id=1824>
> >
> > However, I use neither LMTP nor multidrop, so I need help determining if
> > the attached patch that I made is safe.
> 
> Hm. This is the same sink.c patch but without space changes and should
> thus be easier to review. Please comment:

Oops, my mistake. Yes, this patch is certainly required. This will
also avoid an xfree/xstrdup on every mail. I would even recommend
moving the declaration of parsed_host into the if block.

[OFFTOPIC] While debugging this, I found a weird bug relating to this
SMTP/LMTP mode. It seems that once fetchmail switches to LMTP mode,
there is no going back to SMTP mode. Try this simple fetchmail
command:

$ fetchmail -v --smtphost /this/socket/is/down,localhost

fetchmail sends LHLO to the localhost SMTP server. Note that SMTP
cannot be forced as the user could be running this configuration:

$ fetchmail -v --lmtp --smtphost localhost/port,/this/socket/is/up

where localhost is indeed meant to be an LMTP server.

The situation gets worse if fetchmail sends a bounce message in
between!

-- 
Sunil Shetye.