Re: [fetchmail-devel] [PATCH] Re: fetchmail segfault on 'empty' mail

[Daniel D. <ds...@ge...>]

Sunil Shetye wrote:
> The problem is specific to multidrop mailbox only where the
> duplicate-message killer cannot handle a headerless mail. The attached
> patch should fix this issue. 
> 
> The patch also cleans up the code by calling free() at one point
> only for static variables.

Thanks.

I haven't looked at the freeing changes, but I can confirm that this hunk 
alone would have fixed the problem:


> @@ -936,7 +928,7 @@
>       * to break it in a way that blackholed mail.  Better to pass
>       * the occasional duplicate than to do that...
>       */
> -    if (MULTIDROP(ctl))
> +    if (MULTIDROP(ctl) && msgblk.headers)
>      {
>  	MD5_CTX context;
>  

I also think it probably makes more sense than my change did. Would be great 
to see it included in the next versions of fetchmail :)

Thanks,
Daniel