Re: [fetchmail-devel] [PATCH] imap rfc issues

[Matthias A. <mat...@gm...>]

Sunil Shetye <sh...@bo...> writes:

> The code in imap.c incorrectly indicates that "STORE ... +FLAGS.SILENT"
> has been removed in IMAP4rev1. RFCs 3501 and 2060 clearly state that
> this is supported. This patch uses FLAGS.SILENT for IMAP4rev1 too.

Good catch, thanks a lot. I'm inclined NOT to merge this into 6.3.X
though as it's not strictly a fix, and I fear we might destabilize
fetchmail. I'll take the complete patch for 6.4.0 though and merge on
the SVN trunk.

The nice set of test sites ESR used to have has melted down to five
sites, which is next to useless. We need to raise test sites again...

Given that all the IMAP world talks IMAP4rev1 now, we'd effectively
change default behavior and may run into server bugs we haven't seen
yet, I'll just take:

> Also, fetchmailconf warns of BODY[TEXT] with Netscape IMAP4rev1.
> However, since fetchmail uses BODY.PEEK[TEXT] with an IMAP4rev1
> server, the warning is not required.

...this part for 6.3.1.

> Also, RFC 2060 is obsoleted by RFC 3501.

I know, but haven't reviewed the IMAP code for the clarifications, so
I'd say we'll leave "2060" in 6.3.X, too.

Is there anything that changed between 2060 and 3501 that might affect
fetchmail? If so, I'd appreciate an incremental patch against the SVN
trunk.

-- 
Matthias Andree