[fetchmail-devel] [PATCH 2] Re: mail delivery via smtp broken

[Sunil S. <sh...@bo...>]

Quoting from Matthias Andree's mail on Thu, Nov 10, 2005 at 11:28:28AM +0100:
> Matthias Andree <mat...@gm...> writes:
> 
> > Right. So we'll have -rc9 without this "fetchmailhost for smtphost"
> > behavior and another documentation update.
> 
> Find below the patch I have just committed to SVN.
> It is against 6.2.9-rc8.

The man page documentation part is inconsistent. While fixing it, I
had a look at the smtpaddress code and found potential memory leaks
and bugs in sink.c.

1. parsed_host is not freed in some cases. This happens when the first
smtp server is down in this setup:

poll mailserver
    ...
    smtphost "smtpserver1" "smtpserver2"
    ...

2. parsed_host is being initialized for UNIX socket also. For UNIX
socket, parsed_host should be NULL.

3. If EHLO fails on a UNIX socket, it tries HELO on a network socket!

4. ctl->destaddr is allocated memory in two cases. This memory is
never freed.

5. ctl->destaddr was being assigned in a very convoluted manner.
Since, parsed_host is already set correctly now, it can be used
directly.

Please find a patch attached to fix the documentation and the above
issues.

-- 
Sunil Shetye.