Re: [PATCH] Re: [fetchmail-devel] Re: 6.2.6 fails where 6.2.5 was OK

[Matthias A. <mat...@gm...>]

On Sat, 19 Mar 2005, David Greaves wrote:

> >That is newer code (2005-03-01) in spite of the lower version number
> >(the "6.2.6" snapshot is from 2004-11-10).
>
> I didn't configure --with-ssl :)
> 
> I think this is the correct fix.
> 
> --- fetchmail-6.2.5.991-dg/pop3.c       Sat Mar 19 11:35:59 2005
> +++ fetchmail-6.2.5.991/pop3.c  Sun Feb 27 20:19:35 2005
> @@ -361,10 +361,7 @@ static int pop3_getauth(int sock, struct
>         * These authentication methods are blessed by RFC1734,
>         * describing the POP3 AUTHentication command.
>         */
> -       if (
> -#ifdef SSL_ENABLE
> -           (ctl->use_ssl != FLAG_FALSE) ||
> -#endif /* SSL_ENABLE (*/
> +       if ((ctl->use_ssl != FLAG_FALSE) ||
>            (ctl->server.authenticate == A_ANY) ||
>            (ctl->server.authenticate == A_GSSAPI) ||
>            (ctl->server.authenticate == A_KERBEROS_V4) ||

You've got the patch backwards. Use "diff -ur OLDER NEWER".

Even reading it in the right direction, I don't see what this does - and
how it could possibly fix your problem. use_ssl defaults to false, and
the bug also shows with SSL enabled at compile time and unused in the
configuration.

I can reproduce this on my computer even with the latest SVN code, so I
have debugger fodder. This is a genuine regression from 6.2.5 indeed.

I'll debug this a bit.

-- 
Matthias Andree