[fetchmail-devel] Re: r3995 - trunk

[Graham W. <gr...@mk...>]

On Wed, Nov 10, 2004 at 09:14:37PM +0100, Matthias Andree wrote:
> Graham Wilson <gr...@mk...> writes:
> > What is this and why do we need it?
> 
> This is the best GPL-compatible snprintf/sscanf replacement (including
> varargs variants) that I've been able to find as a separate project.

Why do we want it as a separate project?

> The idea is to get rid of insecure and ugly coding practices such as
> using [v]sprintf or strcat on older systems that lack [v]snprintf, and
> the way we'd seen this integrated in the code was messy:
> 
> [...]

I agree that it is a good idea to get rid of sprintf throughout the
code. Thanks for spearheading the effort.

> I'm not fixed on Trio, if you know something better, we can flush Trio
> and use something else,

I would have gone with a single file implementation of snprintf instead
of using the whole Trio. I don't see why we need to add 54 files when we
could just add one. For example, mutt is known to have a good snprintf
implmentation.

What would you think about using that?

> but I'm not willing to allow the ugly old structure back in.

Agreed.

-- 
gram