Re: [fetchmail-devel] Assorted minor bugs

[Matthias A. <ma...@dt...>]

Brian Candler <B.C...@po...> writes:

> On Mon, Nov 08, 2004 at 01:01:31AM +0100, Matthias Andree wrote:
>> Can you try the tarball from
>> http://home.pages.de/~mandree/tmp/fetchmail-6.2.6.tar.bz2
>
> Thanks for making this interim release.

It's a snapshot, not a release. I deliberately let a tarball escape...

> The bugs were described more fully on fetchmail-friends, but in summary:
>
> (1) There is a completely unnecessary sleep(3) after logging in. I cannot
> see any justification for this; the comment in the code talks about mailbox
> locking and tempfiles, but when the POP3 server has replied "+OK" to a
> login, then it is by its own admission locked and ready to receive commands.
>
> I am guessing this was a workaround for some ancient and broken server, but
> I think it should be removed as it just wastes time and resources.

We'll see what happens. I've removed the sleep for now, it's been
annoying myself for years so much I patched it away, with no ill effect
on common servers.

> (2a) When talking to an SSL server, where the certificate name does not
> match, then annoyingly a 'certificate name mismatch' error is given three
> times. The patch changes it so that this warning is only given if you select
> verbose or sslcertck, to be the same as the other certificate
> warnings/errors.

*Shrug* I don't see how it's printed three times. It's printed once on
my computer. Anyways, I would not want to limit this warning to verbose
or strict mode or similar, it's an important information and needs to be
printed unconditionally. If it annoys the user, tough luck, fix the
configuration or let him complain to the server's admin.

> (2b) When talking to an SSL server, honour the sslcertpath option even if
> sslcertck is not set (currently it is ignored); this allows you to use
> fetchmail -v to get useful information on the certificate chain, even if
> it's not being strictly enforced using sslcertck.

Merged.

> (3) There is a bug where 'showdots' fails to work if there are two 'poll'
> entries in .fetchmailrc; I spent a while chasing this down, and it turns out
> to be an option parsing bug. Full description here:
> http://lists.ccil.org/pipermail/fetchmail-friends/2004-April/008518.html

Merged. Thanks for your efforts in analyzing and fixing this.

Thank you!

-- 
Matthias Andree