[fetchmail-devel] patch review: 2004-05-24-6.2.2-guerrini-pop3x.diff and 2003-05-14-6.2.2-guerrini-pop3x.diff

[Matthias A. <ma...@dt...>]

Greetings,

Rob's patch list mentions two editions of Guiseppe Guerrini's POP3X
patch:

 2003-05-14-6.2.2-guerrini-pop3x.diff
 2004-05-24-6.2.2-guerrini-pop3x.diff

The patch adds a split two-phase fetch for header and body so that
antispam can judge after the header already without the need to download
the whole body.

Guiseppe asked to use instead the updated patch, so I'd suggest that we
strikethru 2003-05-14-6.2.2-guerrini-pop3x.diff and not use it.

Schedule:

The patch is somewhat intrusive and so definitely post-6.2.6 stuff.

I haven't yet tried the patch, my questions:

1. does this have a negative impact on small mails because the header is
   fetched twice and because more turnarounds (round trip delay!) are
   necessary? For small mails, the header can be larger than the body
   easily.

2. will the SMTP listener wait long enough after seeing the envelope
   when the download of the mail body takes long?

3. should this patch's functionality be integrated into the regular POP3 protocol?

4. should perhaps the choice "header/body separately" or "whole mail at
   once" be dependent on the size reported in POP3's LIST response, with
   perhaps a configurable limit?

-- 
Matthias Andree

NOTE YOU WILL NOT RECEIVE MY MAIL IF YOU'RE USING SPF!
Encrypted mail welcome: my GnuPG key ID is 0x052E7D95 (PGP/MIME preferred)