[fetchmail-devel] In medias res ire: patch review

[Matthias A. <ma...@dt...>]

Hi,

after having switched to Graham's repository, I've looked at the first
few patches posted at Rob's site, http://funknet.net/fetchmail/patches/
that I'll list below and discuss in separate posts so we'll have one
thread per patch.

I'm not sure what boldface and asterisk mean in the patch list, but I've
looked at the first five patches to begin somewhere, and I'm giving
descriptions.

#1 2003-05-14-6.2.2-guerrini-pop3x.diff
   http://lists.ccil.org/pipermail/fetchmail-friends/2003-May/007419.html
   (should be dropped per originator's request in favor of the update right)

   updated: 2004-05-24-6.2.2-guerrini-pop3x.diff
   http://lists.ccil.org/pipermail/fetchmail-friends/2004-May/008754.html

   Guiseppe Guerrini writes "my POP3 (non-IMAP) mailbox is often filled
   by lot of spam with big bodies (about 150Kb). The anti-spam option
   works well, but it seems that fetchmail has anyway to download the
   whole message because of a leak of POP3 protocol (it misses a command
   to read the message body alone). In my situation a double read of
   message headers is worth because the bodies are large.  So, I made
   some changes to fetchmail 6.2.2 (path attached). My patch adds the
   new protocol "POP3X", that is actually POP3 with a two-steps fetch: a
   "fetch header" step that sends "TOP n 0", and a "fetch body" that
   sends "RETR" or "TOP n 99999999" and then skips the headers."

#2 2003-05-22-6.2.2-hirsch-keeptopuidl.diff
   http://funknet.net/fetchmail/patches/2003-05-22-6.2.2-hirsch-keeptopuidl.diff

   Jakob Hirsch writes "I wanted to use the "keep" option on a server
   where TOP should be used and saw, that "keep" forces TOP to be
   disabled. On first thought this is sensible, but only if "uidl" is
   not enabled, because then fetchmail can determine which messages are
   new. My patch below fixes this. It also uses this check made for
   peek_cabable to reduce code redundancy."

#3 2003-05-24-6.2.2-andree-keeptopuidl.diff
   http://funknet.net/fetchmail/patches/2003-05-24-6.2.2-andree-keeptopuidl.diff
  
   My own patch as a followup to #2 is more radical, throwing the whole
   TOP stuff out.

#4 2003-07-02-6.2.2-hawkey-bouncetext.diff
   http://lists.ccil.org/pipermail/fetchmail-friends/2003-July/007602.html

   D. J. Hawkey Jr. writes "See the attachment for patches against
   fetchmail-6.2.2 that provides an interface for including an
   user-specified message in bounce messages."

#5 2003-07-21-6.2.2-drieu-smtpname.diff
   http://lists.ccil.org/pipermail/fetchmail-friends/2003-July/007733.html
   http://lists.ccil.org/pipermail/fetchmail-friends/2002-September/002585.html
   http://bugs.debian.org/156592

   Benjamin Drieu: "Here is a small patch to fix Debian bug #156592:
   when an arbitrary port is specified with the smtphost keyword
   (i.e. "smpthost host/port"), port is not stripped from smtp queries
   made by smtp_open, so fetchmail uses invalid email addresses and smtp
   host rejects mail."

-- 
Matthias Andree

NOTE YOU WILL NOT RECEIVE MY MAIL IF YOU'RE USING SPF!
Encrypted mail welcome: my GnuPG key ID is 0x052E7D95 (PGP/MIME preferred)