[fetchmail-devel] Re: [fetchmail]fetchmail loaded into berlios svn repository; mailing lists

[Rob F. <rf...@fu...>]

Matthias Andree wrote:
> - in pop3_getpartialsizes, we may return uninitialized data iff first >
> last (I don't know if this can happen, but I'd like to make the function
> itself surprise free.)

Good plan.

> - in po/POTFILES.in we're effectively listing rcfile_y.c a second
>   time. It is in Makefile.in.in with proper path (top_builddir) and in
>   POTFILES.in again, which makes gettext's makefile prepend top_srcdir -
>   which fails, because rcfile_y.c is generated and hence in builddir.

Odd.  I wonder how got that way and how (if) it ever worked properly.  
There's no RCS history on either of those files, but they were like that 
in 6.2.5.

Will the rcfile_y strings be properly translated if you do this?

Wait a minute.... every other file listed in POTFILES.in already exists.  
So I'm not sure that this is the proper fix....

>  To reproduce the problem:
>  make distclean
>  mkdir build
>  cd build
>  ../configure
>  make

I can't get past the ../configure -- it keeps telling me I need to make 
distclean in the source directory, even though I did.

Argh.  autoconf is great for the user, but quite a pain for the developer.

> The rest is just word flipping to shut up GCC 3.4.

Definitely a good thing.

> Is this OK to commit?

I generally prefer that separate issues be committed separately, but other 
than POTFILES.in, this stuff looks good to me.  I'm still trying to figure 
out the autoconf and gettext stuff so I can even see the rcfiles_y 
problem.


BTW, the uni-dortmund address you sent this from isn't subscribed to 
fetchmail-devel so I had to approve the message there.
-- 
==============================|   "A microscope locked in on one point
 Rob Funk <rf...@fu...> |Never sees what kind of room that it's in"
 http://www.funknet.net/rfunk |    -- Chris Mars, "Stuck in Rewind"