From: Matthias A. <mat...@gm...> - 2007-03-25 17:03:40
|
"Rob MacGregor" <rob...@gm...> writes: > I'd be tempted to go with your second paragraph - if fetchmail is > linked with the socks libraries *and* the required socks config file > is in place then, by default, use socks. As long as there is a > command line argument to either disable socks or use an alternative > socks config file (which implicitly enables socks) then that should be > fine. I have decided to do exactly that, even if it causes pain to those who experiment with socks -- IOW, if you leave shards lying around, wear tough shoes. >> Not my essay, and I'm not enthusiastic about several of the assumptions >> fetchmail makes, and I'm still pondering whether a complete redesign is >> more of an effort than rewriting existing code... > > Which is more effort to maintain :) Need not be your concern though. 8-) > It probably wouldn't hurt for the --configdump option to include the > fact that socks is compiled in - which, in theory, is little more > than: > > #ifdef HAVE_SOCKS > "'socks'," > #endif > > after line 186 of conf.c Done for 6.3.8. Thanks for the report. -- Matthias Andree |