Re: [fetchmail-users] [PATCH] Re: IMAP problem (fetchmail 6.3.1-pre1)

[Matthias A. <mat...@gm...>]

Jason White <jas...@in...> writes:

> On Sat, Dec 17, 2005 at 03:52:30PM +0100, Matthias Andree wrote:
>> Sunil Shetye <sh...@bo...> writes:
>> 
>> > Matthias, please consider this patch for 6.3.1.
>> 
>> I wonder if it's the right thing to do, or if the server of the day
>> might return the flags or some other information along with the size. I
>> had a quick glance at the standard, and I'm not at all sure if it's
>> allowed for the server to return excess information. 
> There is a statemenn section 2.2.2, but I am not sure whether it is meant to
> cover this case:
> "   A client MUST be prepared to accept any server response at all times.
>    This includes server data that was not requested.  Server data SHOULD
>    be recorded, so that the client can reference its recorded copy
>    rather than sending a command to the server to request the data.  In
>    the case of certain server data, the data MUST be recorded.
>
>    This topic is discussed in greater detail in the Server Responses
>    section."
>
> I couldn't find any more specific guidance in section 7, but then I didn't
> read it carefully. Also, this could be read as implying only to entire
> responses and not to additional data included within responses that are
> requested.

Well, I'll just use an equivalent modification of Sunil's patch for
6.3.1, because, after looking at the respective code, the entire IMAP
response parser must be rewritten - for instance, to support the ALERT
response code or * BYE. And this rewrite is stuff for 6.4.0.

We'll just use the minimal change that fixes the problem in 6.3.1. I'll
release 6.3.1-rc1 later, and I'd ask you to test again so that my
changes haven't broken the fix.

-- 
Matthias Andree