fetchmail-devel

[fetchmail-devel] PopDel.py patch to show from address

[Joshua C. <mor...@ya...>]

Here's a patch to PopDel.py to make it also display the From: address of
messages on the server.

I've added this because I almost deleted an email from my mother yesterday.
She'd forwarded me an amusing video file someone had sent to her, and the
Subject: looked rather like spam ("Fw: COMMUNICATION").

Also, I don't know if it's technically possible to have an email with no
Subject header, but previously PopDel would have ignored any that didn't,
causing indexing errors (deleting the wrong mail if it comes after the
Subject-less one). This patch corrects that also, as a byproduct of how I've
implemented the other change.
-- 
Joshua 'bruce' Crawford ... http://www.geocities.com/mortarn

Any fool can criticize, condemn, and complain. And most do.

Re: [fetchmail-devel] PopDel.py patch to show from address

[Matthias A. <mat...@gm...>]

Joshua Crawford <mor...@ya...> writes:

> Here's a patch to PopDel.py to make it also display the From: address of
> messages on the server.
>
> I've added this because I almost deleted an email from my mother yesterday.
> She'd forwarded me an amusing video file someone had sent to her, and the
> Subject: looked rather like spam ("Fw: COMMUNICATION").
>
> Also, I don't know if it's technically possible to have an email with no
> Subject header, but previously PopDel would have ignored any that didn't,
> causing indexing errors (deleting the wrong mail if it comes after the
> Subject-less one). This patch corrects that also, as a byproduct of how I've
> implemented the other change.

Thank you. I have committed these two changes to SVN (on BRANCH_6-3),
to appear in fetchmail 6.3.5.

| ------------------------------------------------------------------------
| r4810 | m-a | 2006-04-27 13:25:07 +0000 (Thu, 27 Apr 2006) | 1 line
| Changed paths:
|    M /branches/BRANCH_6-3/contrib/PopDel.py
| 
| Mention the latest fix is actually a bugfix.
| ------------------------------------------------------------------------
| r4809 | m-a | 2006-04-27 13:23:23 +0000 (Thu, 27 Apr 2006) | 3 lines
| Changed paths:
|    M /branches/BRANCH_6-3/NEWS
|    M /branches/BRANCH_6-3/contrib/PopDel.manual
|    M /branches/BRANCH_6-3/contrib/PopDel.py
|    M /branches/BRANCH_6-3/contrib/README
| 
| PopDel.py was revised by Joshua Crawford to display the From: address and
| list every email, even if it has no Subject: header; and not delete the wrong
| message in the presence of mail without Subject: headers.
| ------------------------------------------------------------------------

The full diff as committed is attached for your reference. I have bumped
the version to 0.1+jc2. On further submissions, you can just increment
the figure after "+jc" (jc3 jc4...) to make clear it's not Richard
Harris's version any more.

Thanks for your contribution!

Kind regards,

-- 
Matthias Andree

Re: [fetchmail-devel] PopDel.py patch to show from address

[Joshua C. <mor...@ya...>]

* Matthias Andree <mat...@gm...> [2006-04-27 15:29 +0200]:
> 
> The full diff as committed is attached for your reference. I have bumped
> the version to 0.1+jc2. On further submissions, you can just increment
> the figure after "+jc" (jc3 jc4...) to make clear it's not Richard
> Harris's version any more.

Will do.

> +		  "     email - Joshua Crawford <mo...@so...>\n"

I haven't used that address for a couple of years, and rarely check it since
free POP access was disabled. Please use jgc...@gm..., which should
be good for years to come :-)
-- 
Joshua 'bruce' Crawford ... http://www.geocities.com/mortarn

"Bad officials are elected by good citizens who do not vote."
		-- G. J. Nathan

Re: [fetchmail-devel] PopDel.py patch to show from address

[Matthias A. <mat...@gm...>]

Joshua Crawford <mor...@ya...> writes:

> * Matthias Andree <mat...@gm...> [2006-04-27 15:29 +0200]:
>> 
>> The full diff as committed is attached for your reference. I have bumped
>> the version to 0.1+jc2. On further submissions, you can just increment
>> the figure after "+jc" (jc3 jc4...) to make clear it's not Richard
>> Harris's version any more.
>
> Will do.
>
>> +		  "     email - Joshua Crawford <mo...@so...>\n"
>
> I haven't used that address for a couple of years, and rarely check it since
> free POP access was disabled. Please use jgc...@gm..., which should
> be good for years to come :-)

Euh, my fault. I looked at the signing GnuPG ID instead, rather than the
From: line, and mistook the GnuPG ID for the From: line...

Sorry!

-- 
Matthias Andree