Re: [Feedreader-development] New Release?

[Marcus H. <hm...@us...>]

Ok, both comments are reflected in the code.

> Comments about build 594:
>
> 1) There's still a bug related to http proxy settings in
> AddOptionsDialog_FRM.pas, line 393:
>
>   If gProperties.ProxyEnabled Then
>     if gProperties.ProxyPassword = '' then
>       if gProperties.ProxyUsername <> '' Then
>         gProperties.ProxyPassword := InputBox( TranslateString('Enter
proxy
> server password'), TranslateString('for user') + ' ' +
> gProperties.ProxyUsername, '');
>
>   gProperties.ProxyEnabled := enableproxy.checked;
>   gProperties.ProxyHost := proxyhost.text;
>   gProperties.ProxyPort := proxyport.text;
>   gProperties.ProxyUsername := proxyusername.text;
>
> As you can see, password dialog window will open even when enableproxy
> checkbox will not be checked because gProperties.ProxyEnabled are checked
> first. You should put those four assignment statement before checking for
> password prompt.
>
> 2) I prefer that minimizing window would not occur on close event
> (MainForm_FRM.pas, TMainWindow.FormCloseQuery). IMO, it is necessary to
> minimize main window before program closing program.
>
> Here's a patch that will not minimize window if program is closing.
>
> Index: MainForm_FRM.pas
> ===================================================================
> RCS file: /cvsroot/feedreader/feedreader/MainForm_FRM.pas,v
> retrieving revision 1.17
> diff -r1.17 MainForm_FRM.pas
> 841c841
> <   if not fProgrammaticApplicationClose then
> ---
> >   if not fProgrammaticApplicationClose then begin
> 843c843,844
> <   application.minimize;
> ---
> >     application.minimize;
> >   end;
>
> or, if you prefer whole code:
>
> procedure TMainWindow.FormCloseQuery(Sender: TObject; var CanClose:
> Boolean);
> begin
>   if not fProgrammaticApplicationClose then begin
>     canclose := false;
>     application.minimize;
>   end;
> end;
>
>
> --
> Miha Remec
>
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by:Crypto Challenge is now open!
> Get cracking and register here for some mind boggling fun and
> the chance of winning an Apple iPod:
> http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en
> _______________________________________________
> Feedreader-development mailing list
> Fee...@li...
> https://lists.sourceforge.net/lists/listinfo/feedreader-development