feedreader-development

[Feedreader-development] New Release?

[Marcus H. <hm...@us...>]

What about a new release?
I think it's time for it. I've fixed some
bugs and we've got new features that
users requested.
Has someone tested the current source-version,
except myself?

Greetings
  Marcus

RE: [Feedreader-development] New Release?

[Miha R. <pb...@mi...>]

Comments about build 594:

1) There's still a bug related to http proxy settings in
AddOptionsDialog_FRM.pas, line 393:

  If gProperties.ProxyEnabled Then
    if gProperties.ProxyPassword = '' then
      if gProperties.ProxyUsername <> '' Then
        gProperties.ProxyPassword := InputBox( TranslateString('Enter proxy
server password'), TranslateString('for user') + ' ' +
gProperties.ProxyUsername, '');

  gProperties.ProxyEnabled := enableproxy.checked;
  gProperties.ProxyHost := proxyhost.text;
  gProperties.ProxyPort := proxyport.text;
  gProperties.ProxyUsername := proxyusername.text;

As you can see, password dialog window will open even when enableproxy
checkbox will not be checked because gProperties.ProxyEnabled are checked
first. You should put those four assignment statement before checking for
password prompt.

2) I prefer that minimizing window would not occur on close event
(MainForm_FRM.pas, TMainWindow.FormCloseQuery). IMO, it is necessary to
minimize main window before program closing program.

Here's a patch that will not minimize window if program is closing.

Index: MainForm_FRM.pas
===================================================================
RCS file: /cvsroot/feedreader/feedreader/MainForm_FRM.pas,v
retrieving revision 1.17
diff -r1.17 MainForm_FRM.pas
841c841
<   if not fProgrammaticApplicationClose then
---
>   if not fProgrammaticApplicationClose then begin
843c843,844
<   application.minimize;
---
>     application.minimize;
>   end;

or, if you prefer whole code:

procedure TMainWindow.FormCloseQuery(Sender: TObject; var CanClose:
Boolean);
begin
  if not fProgrammaticApplicationClose then begin
    canclose := false;
    application.minimize;
  end;
end;


--
Miha Remec

Re: [Feedreader-development] New Release?

[Marcus H. <hm...@us...>]

Ok, both comments are reflected in the code.

> Comments about build 594:
>
> 1) There's still a bug related to http proxy settings in
> AddOptionsDialog_FRM.pas, line 393:
>
>   If gProperties.ProxyEnabled Then
>     if gProperties.ProxyPassword = '' then
>       if gProperties.ProxyUsername <> '' Then
>         gProperties.ProxyPassword := InputBox( TranslateString('Enter
proxy
> server password'), TranslateString('for user') + ' ' +
> gProperties.ProxyUsername, '');
>
>   gProperties.ProxyEnabled := enableproxy.checked;
>   gProperties.ProxyHost := proxyhost.text;
>   gProperties.ProxyPort := proxyport.text;
>   gProperties.ProxyUsername := proxyusername.text;
>
> As you can see, password dialog window will open even when enableproxy
> checkbox will not be checked because gProperties.ProxyEnabled are checked
> first. You should put those four assignment statement before checking for
> password prompt.
>
> 2) I prefer that minimizing window would not occur on close event
> (MainForm_FRM.pas, TMainWindow.FormCloseQuery). IMO, it is necessary to
> minimize main window before program closing program.
>
> Here's a patch that will not minimize window if program is closing.
>
> Index: MainForm_FRM.pas
> ===================================================================
> RCS file: /cvsroot/feedreader/feedreader/MainForm_FRM.pas,v
> retrieving revision 1.17
> diff -r1.17 MainForm_FRM.pas
> 841c841
> <   if not fProgrammaticApplicationClose then
> ---
> >   if not fProgrammaticApplicationClose then begin
> 843c843,844
> <   application.minimize;
> ---
> >     application.minimize;
> >   end;
>
> or, if you prefer whole code:
>
> procedure TMainWindow.FormCloseQuery(Sender: TObject; var CanClose:
> Boolean);
> begin
>   if not fProgrammaticApplicationClose then begin
>     canclose := false;
>     application.minimize;
>   end;
> end;
>
>
> --
> Miha Remec
>
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by:Crypto Challenge is now open!
> Get cracking and register here for some mind boggling fun and
> the chance of winning an Apple iPod:
> http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en
> _______________________________________________
> Feedreader-development mailing list
> Fee...@li...
> https://lists.sourceforge.net/lists/listinfo/feedreader-development

Re: [Feedreader-development] New Release?

[Toomas T. <to...@i-...>]

I have compiled and tested CVS version. Before new release i'd like to 
commit some features i wrote about in previous email. I guess I can do 
it today.

I think that there is some little problem with automatic updating 
engine. I notice that if i let FR to run for example one day it can stop 
updating feeds automatically. Only program restart helps. Even if I push 
update button, it does not trigger update.

And what about bugs that Kyle wrote about:

1) Feedreader sometimes write invalid XML to one of its data files

2) when reading the file back in, it fail to parse, then fail silently with
no error message, yet lose the "read / not read" status of every item in
every feed.  (Code which fails silently in there is an error, is an
extremely bad idea, by the way.)


Greetings
Toomas


Marcus Hettlage ::

> What about a new release?
> I think it's time for it. I've fixed some
> bugs and we've got new features that
> users requested.
> Has someone tested the current source-version,
> except myself?
>  
> Greetings
>   Marcus

Re: [Feedreader-development] New Release?

[Marcus H. <hm...@us...>]

Currently I can't reproduce the problems Kyle described.
I'd like to fix it but I've no idea where it could happen.
As I said I don't have the problem.
  Toomas ::


  I have compiled and tested CVS version. Before new release i'd like to =
commit some features i wrote about in previous email. I guess I can do =
it today.=20

  I think that there is some little problem with automatic updating =
engine. I notice that if i let FR to run for example one day it can stop =
updating feeds automatically. Only program restart helps. Even if I push =
update button, it does not trigger update.

  And what about bugs that Kyle wrote about:


1) Feedreader sometimes write invalid XML to one of its data files

2) when reading the file back in, it fail to parse, then fail silently =
with
no error message, yet lose the "read / not read" status of every item in
every feed.  (Code which fails silently in there is an error, is an
extremely bad idea, by the way.)

  Greetings
  Toomas


  Marcus Hettlage ::

    What about a new release?
    I think it's time for it. I've fixed some
    bugs and we've got new features that
    users requested.
    Has someone tested the current source-version,
    except myself?

    Greetings
      Marcus

Re: [Feedreader-development] New Release?

[Kyle C. <ky...@ky...>]

From: "Toomas Toots" <to...@i-...>


> And what about bugs that Kyle wrote about:
>
> 1) Feedreader sometimes write invalid XML to one of its data files
>
> 2) when reading the file back in, it fail to parse, then fail silently
with
> no error message, yet lose the "read / not read" status of every item in
> every feed.  (Code which fails silently in there is an error, is an
> extremely bad idea, by the way.)


I will hopefully find time soon to send an example of a feed that triggers
this problem.  However, the very existance of code that will fail silently,
is a large problem.  That code needs to fixed, regardless of what specific
example makes it happen.

Kyle