[Alfonso Martinez]

as the context menu isn't available in the editor the
curvy underline of misspelled words are bad, so I think
that it's better to remove it from the main editor and
maybe just allow to popup a new window where a normal
spellchecking can take place.

To disable spellchecking (it might also help to save a
little CPU cycles) just set the attribute spellcheck=false

fckeditingarea.js
FCKEditingArea.prototype.MakeEditable = function()

//disable spellchecking for the main body (Firefox 2.0)
//https://bugzilla.mozilla.org/show_bug.cgi?id=333038
oDoc.body.spellcheck=false;

patch file

Logged In: YES
user_id=1356422

Forget about it.
This can be handled better with a plugin.

• status: open --> closed

• status: closed --> pending

Logged In: YES
user_id=572424

The editor tries to disable the original Firefox context
menu, placing its one, which doesn't have integration with
the spell checking system.

For many users, there is no sense to have the red line,
without its relative context menu. So, there should not be
the red line for then.

But, for others, even without the context menu, it could
result useful to have the red line indicating mistakes.

Don't you think it could be something configurable instead?
Maybe by default it is disabled.

Other users instead, have Firefox configured in a way that
FCKeditor can't replace the Firefox context menu. In those
cases, we could also try to find out it, and leave the spell
checker working only for those users.

Much probably we'll also enable the FCKeditor context menu
on the Ctrl+Left-Click action. So, disabling the customized
right-click context menu would be not a problem.

Well... just some thoughts.

Logged In: YES
user_id=1356422

>
> The editor tries to disable the original Firefox context
> menu, placing its one, which doesn't have integration with
> the spell checking system.
>
Yes, and I don't think that its possible to gain access to
the word suggestions without showing the context menu. That
would be the perfect solution.

> For many users, there is no sense to have the red line,
> without its relative context menu. So, there should not be
> the red line for then.
Yes, that was my aim with this patch. Disable the
spellchecking on the main area to remove the underlines.
>
> But, for others, even without the context menu, it could
> result useful to have the red line indicating mistakes.
But they will find frustating not being able to show the
word suggestions, they need somehow to show the context menu
or they will think that there's some strange underlining
going on that they can't remove.

>
> Don't you think it could be something configurable
> instead?
> Maybe by default it is disabled.
Yes, that's the reason that I've said that this is better
handled with a plugin. I've working code (not finished) that
enables/disables the spellchecking and allows the original
context menu to appear so the user can choose to spellcheck
the contents. For IE users it calls back to the original
spellchecker command.
It's quite clean and doesn't require special configuration
options. I need some testing and save the preference using
the new storage system in Fx2 (cookies on steroids as
someone said), and this will avoid touching a core file.

>
> Other users instead, have Firefox configured in a way that
> FCKeditor can't replace the Firefox context menu. In those
> cases, we could also try to find out it, and leave the spell
> checker working only for those users.
>
I don't know if it is possible to detect if the user has
disabled the option to use a customized context-menu :-(

> Much probably we'll also enable the FCKeditor context menu
> on the Ctrl+Left-Click action. So, disabling the customized
> right-click context menu would be not a problem.
this can be tricky as the user might try to use Ctrl+Left
click to select elements. I remember right now that this is
the way to work with tables in Firefox. But if there are no
problems it's good to have the chance to show that way the
context menu, and I think that it could be also good to show
the original context menu if the Ctrl+right click is pressed
(that's one of my ideas for the plugin so it can allow to
have both context menus without toggling the spellchecking)

• status: pending --> open

Logged In: YES
user_id=572424

Ok... I'll try to find a way to eliminate the lines by
default, but leave it open to a plugin to enable them if needed.

Thanks again Alfonso.

Logged In: YES
user_id=1356422

If you just apply this patch the lines are removed and my
plugin already takes care of enabling or disabling the
spellcheck as needed, no matter the previous state.

The only question would be if you want to always disable the
spellcheck or leave it as a config option (maybe that's the
best way, setting it to false by default).

Logged In: YES
user_id=1356422

ok, I've finished the coding and here it's the plugin:
https://sourceforge.net/tracker/index.php?func=detail&aid=1581776&group_id=75348&atid=737639

• assigned_to: nobody --> fredck

• status: open --> closed

Logged In: YES
user_id=572424

Hi,

This patch, or a similar implementation, has been included in
FCKeditor and has been committed in the SVN. It will be available
in the next release.

For more information about the FCKeditor SVN system, please use
the following URL:
http://wiki.fckeditor.net/SVN

Best regards,
Frederico Caldeira Knabben
----
http://www.fckeditor.net
"Support Open Source Software"

PS.: This is a canned response.