[Alfonso Martinez]

Currently the code generated for popup links is not
good from the point of view of accesibility and the
people that might visit the web with javascript disabled.

This is the code generated:
<a
href="javascript:void(window.open('http://www.fckeditor.net/','','resizable=no,location=no,menubar=no,scrollbars=no,status=no,toolbar=no,fullscreen=no,dependent=no'))">FCKeditor</a>.

As the problem with onclick handlers has been fixed in
2.3.2 now it's possible to generate better code: put
the real link in the href and add an onclick handler
that does the popup if javascript is enabled

<a
onClick="window.open(this.href,'','resizable=no,scrollbars=no,status');
return false"
href="http://www.fckeditor.net">FCKeditor</a>.

(the difference in the number in attributes is due to
the fact that I did remove "useless" ones from my
implementation)

This kind of implementation is neccesary for any web
that tries to follow the WAI guidelines or if you care
about robots spidering your site.

The following patch (for
(editor/dialog/fck_link/fck_link.js) keeps the code to
understand existing popups but when writing a link
again it will always use the accesible pattern, so it
doesn't need any other special setup of upgrade changes.
The file had other changes non related to this patch so
I've tried to remove them from the patch, I hope that
it didn't break anything manually editing the patch file.

Patch file

Logged In: YES
user_id=1562006

Hi,

Nice patch, but it seems I can't get it to understand/update existing popup links. Any idea ?

Logged In: YES
user_id=1356422

This patch doesn't automagically change all the links in
your documents, it just makes sure that new links are
generated properly and if you edit an existing link then it
will be saved in the new format, but the rest of the links
of that very same document will remain untouched.
If I didn't mess it up while extracting the patch code from
other changes then it should work as I have said.

Logged In: YES
user_id=1562006

Sorry, I wasn't clear, but it's also what I meant, I don't believe in magic either ;)
I'll try again, though, and will let you know. Maybe it's our integration who messes up !

Logged In: YES
user_id=1562006

Ok, sorry this works perfectly !!
Our integration code was messing up :)
I hope this makes its way into the main codebase soon !

• assigned_to: nobody --> alfonsoml

Logged In: YES
user_id=1356422
Originator: YES

This patch, or a similar implementation, has been included in
FCKeditor and has been committed in the SVN. It will be available
in the next release.

For more information about the FCKeditor SVN system, please use
the following URL:
http://wiki.fckeditor.net/SVN

----
http://www.fckeditor.net
"Support Open Source Software"

PS.: This is a canned response.

• status: open --> closed-fixed