#257 EmptyLinkPatch - create link text for new empty links

Version 2.x
closed
Editor (144)
5
2006-06-02
2006-05-26
dom
No

This little patch will change FCKeditor's behavior
(discarding link settings) for adding empty links. This
could happen if you click on »Insert/Edit link« without
selection.

After applying this patch a new link text (uri path or
email address) will be created and the link (with it's
settings) will be added.

The link text contains the uri path (without http://
and [?…]) or the email address (without mailto: and [?…]).

Apply this patchfile to /editor/dialog/fck_link/fck_link.js

(tested in MSIE 6.x, Firefox 1.5.x)

Discussion

  • Frederico Caldeira Knabben

    Logged In: YES
    user_id=572424

    Hi,

    I was about to take a look at your patch, but you have not
    uploaded it. Maybe because of the (stup..) SourceForge
    checkbox to check when uploading.

    Could you please check it?

    Thanks in advance.

    Best regards,
    Frederico Caldeira Knabben
    ----
    http://www.fckeditor.net
    "Support Open Source Software... What about a donation
    today?"

     
  • Frederico Caldeira Knabben

    • status: open --> pending
     
  • dom

    dom - 2006-06-02
    • status: pending --> open
     
  • dom

    dom - 2006-06-02

    Logged In: YES
    user_id=1228441

    sorry, the file is now online

     
  • Frederico Caldeira Knabben

    • assigned_to: nobody --> fredck
     
  • Frederico Caldeira Knabben

    Logged In: YES
    user_id=572424

    Hi again dom,

    I've applied your patch, with many changes. Actually the
    following block of code was bringing problems when creating
    link next to links:

    // select/deselect for redraw
    oEditor.FCKSelection.SelectNode(oLink);
    oLink = oEditor.FCK.CreateLink(sUri);
    oEditor.FCKSelection.Collapse(false);

    Why were you doing this? I've noticed that the link was not
    appearing, but it was enough to set the src to make it run.
    The following code instead of the above:

    oLink.href = sUri ;

    Are there any other reasons for that?

    Thanks again.

    Best regards,
    Frederico Caldeira Knabben
    ----
    http://www.fckeditor.net
    "Support Open Source Software... What about a donation
    today?"

     
  • dom

    dom - 2006-06-02

    Logged In: YES
    user_id=1228441

    Hi Frederico,

    > Are there any other reasons for that?

    No. Please excuse: I thought it was the
    only way to correct the »link appearing«.

    Best regards
    Dominik Pesch (dom)

     
  • Frederico Caldeira Knabben

    • status: open --> closed
     
  • Frederico Caldeira Knabben

    Logged In: YES
    user_id=572424

    Hi,

    This patch, or a similar implementation, has been included in
    FCKeditor and has been committed in the SVN. It will be
    available in the next release.

    For more information about the FCKeditor SVN system, please use
    the following URL:
    https://sourceforge.net/svn/?group_id=75348

    Best regards,
    FredCK
    http://www.fckeditor.net
    "Support Open Source Software... What about a donation today?"

    PS.: This is a canned response.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks