[Alfonso Martinez]

It seems that the popup-blocker of the Yahoo toolbar
makes the window.open call return "something" (I don't
know what it is) so the detection to present the user
with a warning and avoid errors fails.

This solution seems to work:
in dialog\common\fck_dialog_common.js add a new check
in OpenFileBrowser:

// The "PreserveSessionOnFileBrowser" because the
above code could be
// blocked by popup blockers.
if ( oEditor.FCKConfig.PreserveSessionOnFileBrowser &&
oEditor.FCKBrowserInfo.IsIE )
{
// The following change has been made otherwise IE
will open the file
// browser on a different server session (on some cases):
//
http://support.microsoft.com/default.aspx?scid=kb;en-us;831678
// by Simone Chiaretta.
var oWindow = oEditor.window.open( url,
'FCKBrowseWindow', sOptions ) ;

if ( oWindow )
//detect Yahoo popup blocker:
try{
var tmp = oWindow.name ; //Yahoo returns
"something", but we can't access it, so detect that and
avoid strange errors for the user.
oWindow.opener = window ;
}
catch(e)
{
alert( oEditor.FCKLang.BrowseServerBlocked ) ;
}
else
alert( oEditor.FCKLang.BrowseServerBlocked ) ;
}
else
window.open( url, 'FCKBrowseWindow', sOptions ) ;

[Frederico Caldeira Knabben]

Logged In: YES
user_id=572424

Hello Alfonso,

I've just installed the Yahoo toolbar in both IE and
Firefox. I tested it using PreserveSessionOnFileBrowser set
to "true" and "false".

I had no strange errors. When the File Browser is blocked,
the correct alert message is presented.

I've noticed the the Yahoo popup blocker blocks (sometimes)
the editor dialogs, like Image Properties. No message is
available in those cases, so I'm introducing the correct
message there. But nothing wrong with the File Browser.

Am I missing something? How to reproduce it.

Thanks in advance.

Best regards,
Frederico Caldeira Knabben
----
http://www.fckeditor.net
"Support Open Source Software... What about a donation
today?"

[Frederico Caldeira Knabben]

• status: open --> pending

[Alfonso Martinez]

• status: pending --> open

[Alfonso Martinez]

Logged In: YES
user_id=1356422

The test enviroment is windows XP + SP2 with IE
6.0.2900.2180 etc...
I can't find the Yahoo toolbar version, but it was installed
that day just to find the reason of this problem.

Both the IE and Yahoo popup blockers are enabled, and the
error happens trying to select an image launching the image
properties dialog and clicking the browse server button.
First time the IE blocker will block it and that is detected
by the editor as well as the infobar appears on the editor
window
(of course PreserveSessionOnFileBrowser is enabled or I
wouldn't be following that code path)

So the IE blocker is changed to accept popups, and now
clicking again the browse server button "nothing happens",
no alert is shown, no error, no popup, nothing, just an
"unfocus" of the current window but nothing more.

So we do a little test and change that code to

var oWindow = oEditor.window.open( url, 'FCKBrowseWindow',
sOptions ) ;

if ( oWindow )
//detect Yahoo popup blocker:
{
var tmp = oWindow.name ; //Yahoo returns "something",
but we can't access it, so detect that and avoid strange
errors for the user.
oWindow.opener = window ;

}
else
alert( oEditor.FCKLang.BrowseServerBlocked ) ;

now upon clicking the button an error appears saying "Access
denied", so putting a try..catch block around it detects the
problem and the user is warned about the problem.

Indeed the user that told about the problem was seeing some
errors upon clicking the server browse that I didn't found
but he had the IE popup blocker, Yahoo, Norton antivirus and
firewall and maybe something more. Once the message was
shown he was able to understand that the problem was on his
side and not on the editor.

If neccesary I could give you VNC access to a machine with
the correct setup, but I think that just putting the
try..catch block is enough to prevent any further problem
with any popup blocker.

Regards.

[Frederico Caldeira Knabben]

• assigned_to: nobody --> fredck

[Frederico Caldeira Knabben]

• status: open --> closed

[Frederico Caldeira Knabben]

Logged In: YES
user_id=572424

Hi,

This patch, or a similar implementation, has been included in
FCKeditor and has been committed in the SVN. It will be
available in the next release.

For more information about the FCKeditor SVN system, please use
the following URL:
https://sourceforge.net/svn/?group_id=75348

Best regards,
FredCK
http://www.fckeditor.net
"Support Open Source Software... What about a donation today?"

PS.: This is a canned response.