#182 Patches for handling of flash in IE

Version 2.x
closed-fixed
Editor (144)
5
2005-12-23
2005-11-28
No

tested in IE6, wXP, there are 3 issues:

After adding a Flash movie, if the movie is selected
and the properties dialog opens again the class isn't
remembered.
In fck_flash.js read and write the class using
className for IE:
Reading:
if ( oEditor.FCKBrowserInfo.IsIE )
{
GetE('txtAttClasses').value =
oEmbed.getAttribute('className') || '' ;
GetE('txtAttStyle').value = oEmbed.style.cssText ;
}
else
{
GetE('txtAttClasses').value =
oEmbed.getAttribute('class',2) || '' ;
GetE('txtAttStyle').value =
oEmbed.getAttribute('style',2) ;
}

Writing:
if ( oEditor.FCKBrowserInfo.IsIE )
{
SetAttribute( e, 'className' ,
GetE('txtAttClasses').value ) ;
e.style.cssText = GetE('txtAttStyle').value ;
}
else
{
SetAttribute( e, 'class' ,
GetE('txtAttClasses').value ) ;
SetAttribute( e, 'style', GetE('txtAttStyle').value ) ;
}

2nd issue:
The values of the checkboxes autoplay, repeat and menu
don't get activated if previously the flash had them
disabled.
fix in fck_flash.js UpdateEmbed
SetAttribute( e, 'play', GetE('chkAutoPlay').checked ?
'true' : 'false' ) ;
SetAttribute( e, 'loop', GetE('chkLoop').checked ?
'true' : 'false' ) ;
SetAttribute( e, 'menu', GetE('chkMenu').checked ?
'true' : 'false' ) ;

3rd issue:
in IE the values of the special attributes embed aren't
remembered after realoading the code or just going from
WYS to source mode and back to WYS.

In fck_1.js, FCKFlashProcessor.ProcessDocument copy
those attributes as cloneNode doesn't do the work:

var oCloned=oEmbed.cloneNode(true);
if ( FCKBrowserInfo.IsIE )
{
oCloned.setAttribute( 'scale' ,
oEmbed.getAttribute( 'scale' ) );
oCloned.setAttribute( 'play' , oEmbed.getAttribute(
'play' ) );
oCloned.setAttribute( 'loop' , oEmbed.getAttribute(
'loop' ) );
oCloned.setAttribute( 'menu' , oEmbed.getAttribute(
'menu' ) );
}

var oImg = FCKDocumentProcessors_CreateFakeImage(
'FCK__Flash', oCloned ) ;

Discussion

  • Frederico Caldeira Knabben

    • assigned_to: nobody --> fredck
    • status: open --> open-fixed
     
  • Frederico Caldeira Knabben

    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks