#506 Use system minizip

SDL
closed:fixed
None
1
2013-03-10
2012-04-22
No

The attached patch makes use of the system installed libminizip instead of the bundled copy provided in the sources.

To completely delete the local copy, you also must:
rm -rf src/utils/unzip.*
sed -i 's/^unzip.cpp//' src/utils/SConscript

The reasons not to use a bundled library are well described here:
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

Please note that even other distributions have a similar policy. E.g. Debian and Gentoo:
http://www.debian.org/doc/debian-policy/ch-source.html#s-embeddedfiles
https://wiki.gentoo.org/wiki/Why_not_bundle_dependencies

Discussion

  • zeromus

    zeromus - 2012-04-22

    i cannot find minizip anywhere in my debian packages. therefore i am not confident in the widespread availability of this package, which would render it difficult to build. this is a good reason to use a bundled copy. in some years when this has changed, we will re-assess the matter. luckily your patch is tiny and tidy so it shouldnt be hard to work it into the fedora packaging pipeline.

     
  • AnS

    AnS - 2012-11-08
    • status: pending --> open
    • milestone: --> SDL
     
  • Lukas Sabota

    Lukas Sabota - 2013-03-10

    r2860 introduces a build variable "SYSTEM_MINIZIP" that directs scons to dynamically link the minizip that is installed on the system instead of using the fceux-provided minizip. thank you for bringing this to our attention. Let us know if you have any other questions.

     
  • Lukas Sabota

    Lukas Sabota - 2013-03-10
    • status: open --> closed:fixed
    • assigned_to: Lukas Sabota
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks